Closed Bug 813383 Opened 9 years ago Closed 9 years ago

Use firstElementChild/lastElementChild/nextElementSibling instead of firstChild/lastChild/nextSibling when possible

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
There are a couple loops within socialchat.xml that use firstChild/nextSibling/lastChild to iterate through the chats, but it actually only cares about the <chatbox> elements.

I attached a patch to clean this up. I didn't touch the
> this.selectedChat = aChatbox.previousSibling ? aChatbox.previousSibling : aChatbox.nextSibling
line since bug 808235 already fixes this instance.
Attachment #683385 - Flags: review?(felipc)
Attachment #683385 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/1aab9de3c554
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.