Closed
Bug 813383
Opened 12 years ago
Closed 12 years ago
Use firstElementChild/lastElementChild/nextElementSibling instead of firstChild/lastChild/nextSibling when possible
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: jaws, Assigned: jaws)
Details
Attachments
(1 file)
|
2.21 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
There are a couple loops within socialchat.xml that use firstChild/nextSibling/lastChild to iterate through the chats, but it actually only cares about the <chatbox> elements. I attached a patch to clean this up. I didn't touch the > this.selectedChat = aChatbox.previousSibling ? aChatbox.previousSibling : aChatbox.nextSibling line since bug 808235 already fixes this instance.
Attachment #683385 -
Flags: review?(felipc)
|
||
Updated•12 years ago
|
Attachment #683385 -
Flags: review?(felipc) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1aab9de3c554
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1aab9de3c554
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•