813462 - Unable to send SMS from Contacts details

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[:gerard-majax]

gecko: 0e7d3d2661760a3552fadc3164178e237058a954
gaia: b3344d5021137b59e98855d2c01badc8c3bf27c4

1- Open existing Contact
2- Tap "Message" button to send a message

Expected:
Open SMS app in edit mode with contact phone number filled.

Actual:
Nothing.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

WFM with latest gecko + gaia.

Comment 2

[:gerard-majax]

Still reproducing with gaia at d42e3c9aea75cf6bae8395955954d272f9b0566f.

Comment 3

[:gerard-majax]

It's actually NOT solved.

Comment 4

[:gerard-majax]

As far as I can tell, logcat does NOT shows "is not from user input" when I hit this issue: so it's not blocked by the recent activies changes to only allow those that results from a user input.

Comment 5

[:gerard-majax]

After digging,
http://mxr.mozilla.org/mozilla-central/source/dom/activities/src/ActivitiesService.jsm#282 checks that the started activity has the correct fields regarding the manifest it evaluates.

In my case, it gives this activity:
I/Gecko   (   77): -- ActivitiesService.jsm 1353514648021 StartActivity: {"id":"{90304520-a147-4805-9755-e233ff1fe68a}","options":{"name":"new","data":{"type":"websms/sms","number":"+336xxxxxxxx"}},"manifestURL":"app://communications.gaiamobile.org/manifest.webapp","pageURL":"app://communications.gaiamobile.org/contacts/index.html"}

And that manifest being tested:
{"manifest":"app://sms.gaiamobile.org/manifest.webapp","name":"new","title":"Messages","icon":"app://sms.gaiamobile.org/style/icons/Sms.png","description":{"filters":{"type":"websms/sms"},"disposition":"window","href":"app://sms.gaiamobile.org/index.html"},"id":"e02Mrwao2k/LmuvMr4gbRBNHHyo="}

Obivously, the 'number' property is not present in description.filters.

Comment 6

[:gerard-majax]

I think it comes from the fix of bug 805292.

Comment 7

[Borja Salguero [:borjasalguero]]

From SMS App it's impossible to create a Contact as well ... :(

Comment 8

[Andrea Marchesini [:baku]]

The bug is that, in Bug 805292, comment 6, I wrote:

App: { type: 'foo', probA: ['a', 'b', 'c'], probB: 42 }
Request: { propC: 'foobar' }
Status: Reject - propC is unknown

This is wrong. If the property 'propC' is in the request, but it's unknown by the app, we should accept the app.

Comment 9

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 10

[Mounir Lamouri (:mounir)]

Comment on attachment 684396 [details] [diff] [review]
patch

Review of attachment 684396 [details] [diff] [review]:
-----------------------------------------------------------------

This is hacky because that means you can create an activity with no payload and have *all* handlers showing up. But given how fkd up our filtering mechanism is, I guess we could try this solution.

Comment 11

[Andrea Marchesini [:baku]]

I agree. I would like to have a filter validation, or filter type, as such as:

"filters": {
  "number": { type: "string", required: true },
  "type": { type: "fixed", value: "sms" }
}

but I think now it's too late to change the manifest syntax. is it?

Comment 12

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2462d9a974

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9e2462d9a974

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/54256fb9dc20
https://hg.mozilla.org/releases/mozilla-beta/rev/7d1ed72ee20c

Comment 16

[[:fabrice] Fabrice Desré]

(In reply to Andrea Marchesini (:baku) from comment #11)
> I agree. I would like to have a filter validation, or filter type, as such
> as:
> 
> "filters": {
>   "number": { type: "string", required: true },
>   "type": { type: "fixed", value: "sms" }
> }
> 
> but I think now it's too late to change the manifest syntax. is it?

I don't think it is. We need some kind of schema language (ouch) to define the filters.