813563 - Firefox process doesn't close with bug 813572 (Conduit toolbars)

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0 RCbuild2

Having Yandex Community Toolbar3.15.1.0 or Hotspot Shield Community Toolbar3.15.1.0 add-on installed, "Restore Previous Session" button is removed from about:home page and from History menu

Reproducible: always (about 10 tries)

Steps:
1. Install Yandex Community Toolbar3.15.1.0 or Hotspot Shield Community Toolbar3.15.1.0 add-on
(http://ct57527.ourtoolbar.com/, http://hotspotshield.ourtoolbar.com/)
2. Open a few tabs (pinned tabs, as well)
3. Make sure "Show my home page" is selected for startup in Options
4. Close Firefox
5. Start firefox

Expected result: about:home page is displayed (and pinned tabs) containing the restore previus session button. "Restore Previous Session" option is enabled unde History menu

Actual result: about:home page is displayed (and pinned tabs) but restore previous button is not visible. "Restore Previous Session" option is disabled in History menu.

Reproducible also on Firefox 16.0.2

Comment 1

[u279076]

Does this only reproduce on Linux? What about Firefox versions before 16.0.2?

Comment 2

[Mihaela Velimiroviciu (:mihaelav)]

On thorough investigation, the problem is caused by Firefox process still running after Firefox is closed (so it cannot restore "previous" session since it runs in the same session).
Also, I cannot reproduce the issue constantly anymore (it is intermittent).

Comment 3

[u279076]

Mihaela, please try to find out a reproducible test for this bug. Dataloss is a serious issue.

Comment 4

[Mihaela Velimiroviciu (:mihaelav)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #3)
> Mihaela, please try to find out a reproducible test for this bug. Dataloss
> is a serious issue.

I reproduced again the process hanging after closing firefox, using the following steps:
1. Start firefox with a new profile
2. In stall 4shared.com toolbar (http://downloadmytoolbar.com/4shared/LP/download.html)
3. Restart firefox
4. Try to open some new tabs (quickly clicking on the new tab button - "+")
-> bug #813572 occurs
5. Close firefox from the "X" button
6. Check if firefox process is closed (ps -e | grep firefox)
Actual result: Process is still running

Comment 5

[u279076]

So this isn't just Yandex and Hotspot then, it's probably all Conduit-based toolbars.

Comment 6

[u279076]

I can't reproduce this in Firefox 15.0, 16.0, 16.0.2.
I can reproduce this with Firefox 17.0. It would seem that if this is our regression, it started in Firefox 17. Now looking for a better regression range.

Comment 7

[u279076]

Last Good: 2012-08-18
First Bad: 2012-08-19

Pushlog: 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=812ea773f166&tochange=8c85c83068e7

Mihaela, please work on the mozilla-inbound builds to see if you can regress this further.

Alex, I'm nominating this for tracking as it appears to be a Firefox 17 regression in relation to Conduit toolbars.

Comment 8

[Shiran Conduit]

Hi,
My name is Shiran and I'm from the support team in Conduit. 

Just to clear something, are we talking only on Linux OS?

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

We've reached out to developers on the Conduit side, looks like this should be a fix on their side at this point, renom if that changes after investigation by extension devs.

Comment 10

[Mihaela Velimiroviciu (:mihaelav)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #7)
> Last Good: 2012-08-18
> First Bad: 2012-08-19
> 
> Pushlog: 
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=812ea773f166&tochange=8c85c83068e7
> 
> Mihaela, please work on the mozilla-inbound builds to see if you can regress
> this further.
> 
> Alex, I'm nominating this for tracking as it appears to be a Firefox 17
> regression in relation to Conduit toolbars.

I could not reproduce on inbound with the provided pushlog (by locally bisecting and building firefox). I could not reproduce on August 19 Nightly, either

Comment 11

[u279076]

(In reply to Mihaela Velimiroviciu [QA] (:mihaela) from comment #10)
> I could not reproduce on inbound with the provided pushlog (by locally
> bisecting and building firefox). I could not reproduce on August 19 Nightly,
> either

I don't understand. That means your regression range is wrong and you can't reproduce this anymore at all?

Comment 12

[Shiran Conduit]

Hi
Please let me know if the issue still reproduced

Comment 13

[u279076]

Mihaela, please find reliable steps to reproduce this bug. If you can't, reproduce this anymore, resolve WORKSFORME.

Comment 14

[Mihaela Velimiroviciu (:mihaelav)]

The toolbars' version available at the provided links has changed to 3.16.0.3, so I guess that's why I cannot reproduce anymore, even with the build from bug description.
Marking WORKSFORME for now.