813587 - When performing global searches with very few characters the browser may become unresponsive

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=805759#c3.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

How does this feel?
The timeout delay now linearly decreases as the user types more chars. I also extended this exact same functionality to the variables view, since we're potentially dealing with thousands of nodes over there.

Comment 2

[Victor Porof [:vporof][:vp]]

(It's worth noting that you can now work around the delay by pressing return. So even if the current search is scheduled after the next second (e.g "!a"), pressing enter would force the search to happen immediately).

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 683637 [details] [diff] [review]
v1

Review of attachment 683637 [details] [diff] [review]:
-----------------------------------------------------------------

This feels good now. The delays I now get at github and gmail are caused by loading the script in orion and transmitting it over the protocol.

::: browser/devtools/shared/VariablesView.jsm
@@ +243,5 @@
> +  performSearch: function VV_performSearch(aQuery) {
> +    this.window.clearTimeout(this._searchTimeout);
> +    this._searchFunction = null;
> +    this._startSearch(aQuery);
> +  },

These methods seem like candidates for reuse among  VariablesView.jsm and debugger-pane.js. Perhaps we should get a debugger-shared.jsm at some point?

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #3)
> 
> These methods seem like candidates for reuse among  VariablesView.jsm and
> debugger-pane.js. Perhaps we should get a debugger-shared.jsm at some point?

That, and quite a few others, like the create() function. However, I still feel it's a bit premature for another jsm. In a few months, perhaps :)

Comment 5

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/8f540f781420

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/8f540f781420

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 683637 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): On pages with very large minified scripts, automatic searches can choke while the user is typing.
User impact if declined: Not typing a search query fast enough would freeze the browser for a few seconds.
Testing completed (on m-c, etc.): fx-team and m-c
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 683637 [details] [diff] [review]
v1

New feature, low risk, developer tools only, approving.

Comment 9

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d3ef0ee45477