813850 - Disable console by default in release builds

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Dave Hylands [:dhylands]]

This was originally done as part of bug 794599, but bug 813791 undid that.

So we need to do this properly on the gaia side of things.

gaia's Android.mk sets PRODUCTION=1, so we should NOT pass in --console to settings.py when PRODUCTION=1 and we're doing a device build (it's probably fine to leave the console enabled for desktop builds).

Comment 1

[Dave Hylands [:dhylands]]

Reminder (probably to me, but for whoever fixes this): Notify dev-b2g and dev-gaia when this bug lands. Also add the ability to override the default from B2G/.userconfig

Comment 3

[Dave Hylands [:dhylands]]

So I'll ask for some feedback under exactly which conditions the console should be disabled.

gaia's Makefile has this PRODUCTION variable which currently seems to be set to 1 for user and userdebug builds and set to 0 for eng builds.

I have access to the TARGET_BUILD_VARIANT variable for device builds as well.

So I was going to propose the if TARGET_BUILD_VARIANT == user then we turn the console off, and for all other cases we turn on. Does that sound reasonable?

Or should PRODUCTION != 1 mean turn the console off?

Comment 4

[Dave Hylands [:dhylands]]

(In reply to Dave Hylands [:dhylands] from comment #3)
> Or should PRODUCTION != 1 mean turn the console off?

Umm PRODUCTION == 1 mean turn console off?

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We should turn this off for "user" builds only, since tests are run against userdebug and we want to see console output there by default.

Comment 6

[Dave Hylands [:dhylands]]

Attachment: Disables console for VARIANT=user builds

Comment 7

[Dave Hylands [:dhylands]]

Comment on attachment 709959 [details] [diff] [review]
Disables console for VARIANT=user builds

And oh yeah - this is modifying gaia/Makefile

Comment 8

[Dave Hylands [:dhylands]]

Merged in gaia/master branch
https://github.com/mozilla-b2g/gaia/commit/888ba530b9f4f9119add284d98d616ea8f2348f1

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: e312ee4ae3209edfd177353767205b114f536b81
v1.0.0: 604a41421bcae4692b07948c65d6b5ea9680bdb2

Comment 10

[amiller]

Does not make sense to create a regression issue.

Comment 11

[Cody Roesch [:croesch]]

Build: 20130322070202
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/5aacf880400b
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
Kernel: Dec 5th

In the build above, I've verified that the option for Console is indeed OFF by default in the dev settings.