813861 - needinfo is sending duplicate request emails when the flag is cleared

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

when a needinfo flag is cleared, duplicate emails are being generated and sent.

eg.  callek received two identical emails (except for message-id) as a result of bug 798791 comment 9

Comment 1

[:glob ✱]

it's the request email which is being duplicated, not the normal "bug updated" bugmail.
this means only the flag setter is receiving duplicates.

Comment 2

[:glob ✱]

Attachment: patch v1

since the move to bug_start_of_update, we no longer need to call Bugzilla::Flag->update_flags, as this is handled by bug->update().

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 683894 [details] [diff] [review]
patch v1

Review of attachment 683894 [details] [diff] [review]:
-----------------------------------------------------------------

Sigh. Sorry I didn't recognize that before. r=dkl On the bright side, the extension is getting shorter and shorter now with the new hook ;)

Also please remove 

    my $timestamp = $args->{timestamp};
    my $changes   = $args->{changes};

on checkin as they are no longer used.

Comment 4

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/Needinfo/Extension.pm
Committed revision 8397.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Needinfo/Extension.pm
Committed revision 8423.

Comment 5

[Wayne Mery (:wsmwk)]

saw one today from standard8's update 
needinfo canceled: [Bug 741601] test pilot thunderbird performance slowdowns

Comment 6

[David Lawrence [:dkl]]

(In reply to Wayne Mery (:wsmwk) from comment #5)
> saw one today from standard8's update 
> needinfo canceled: [Bug 741601] test pilot thunderbird performance slowdowns

Yeah the code push containing the fix is not yet in production and will likely not be out til next week due to IT blocking updates over the US holiday.

dkl