Closed
Bug 814269
Opened 13 years ago
Closed 13 years ago
Social API <xul:key>s should be disabled by default
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: jaws, Assigned: markh)
Details
Attachments
(1 file, 1 obsolete file)
|
2.50 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
The Social API <key>s are currently enabled by default (lacking disabled="true").
STR:
Have social.enabled=false and social.active=false
Open the Error Console and clear the current contents
Press Ctrl+Shift+L to share the current webpage
Expected:
No error in the error console.
Actual:
Timestamp: 11/21/2012 9:10:36 PM
Error: Can't share page as no provider port is available
Source File: resource:///modules/Social.jsm
Line: 116
These keys should not execute if Social.enabled=false.
For example, the share key should only work if the page can be shared and a focus-chatbar key should only work if there are chats open.
|
Assignee | |
Comment 1•13 years ago
|
||
The patch in bug 808422 disables the Social:FocusChat command/key - the only other remaining one current seems to be Social:SharePage. Note this patch should be applied on top of the one from 808422.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #684998 -
Attachment is obsolete: true
Attachment #684998 -
Flags: review?(jaws)
Attachment #685000 -
Flags: review?(jaws)
|
Reporter | |
Updated•13 years ago
|
Attachment #685000 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•