814382 - Can't change encoding for source view in TB17

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Serg Iv]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

1. Write something
2. Save to Draft
3. Click on message, press CTRL-U
4. Try to change encoding 


Actual results:

JS error message.
Please look here for the screenshot http://forums.mozillazine.org/viewtopic.php?f=31&t=2620667

Comment 1

[David Lechner (:dlech)]

This appears to affect all messages, not just drafts.

More specific steps to reproduce.

1. In 3-pane, select any message
2. View > Message Source (or CTRL+U)
3. In Source View windows, View > Character Encoding > (something different)

Reproduced on trunk, windows, linux. 

Firefox uses same source view window, but changing encoding does not cause error, so this is Thunderbird specific.

Comment 2

[David Lechner (:dlech)]

This error was also reported in Bug 779087

Comment 3

[WADA:World Anti-bad-Duping Agency]

Problem was oberved in released Thunderbird 17.0. Not in trunk only. 
Alert shown by Tb 17.0 on Win-XP.
> [Javacrip Appliction]
> !  [... "Component returned failure code: 0x805e0006 [nsIWebNavigation.reload]"  nsresult:
>    "0x805e0006 (<unknown>)"  location: "JS frame :: chrome://global/content/bindings/browser.xml ::
>     reloadWithFlags :: line 103"  data: no]
>                                             [ OK ]

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 5

[Mark Banner (:standard8)]

Sorry for not responding here earlier. I think this is probably ok, though I'd like to dig into it a bit more.

As it changes the content policy, it definitely does need tests before we land it.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug814382_view_source_change_encoding_broken.patch

With tests.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 793934 [details] [diff] [review]
bug814382_view_source_change_encoding_broken.patch

Looks good, thanks.

Comment 8

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/448a69267a0c -> FIXED

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 793934 [details] [diff] [review]
bug814382_view_source_change_encoding_broken.patch

Would be nice to see this make tb24.

Comment 10

[Justin Wood (:Callek)]

I'd love this for SeaMonkey's release as well. Mark?

Comment 11

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/a3574e532501
https://hg.mozilla.org/releases/comm-beta/rev/24b90b84740f