Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Can't change encoding for source view in TB17

RESOLVED FIXED in Thunderbird 26.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Serg Iv, Assigned: Magnus Melin)

Tracking

({regression})

Trunk
Thunderbird 26.0
regression
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird24 fixed, thunderbird25 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

1. Write something
2. Save to Draft
3. Click on message, press CTRL-U
4. Try to change encoding 


Actual results:

JS error message.
Please look here for the screenshot http://forums.mozillazine.org/viewtopic.php?f=31&t=2620667
This appears to affect all messages, not just drafts.

More specific steps to reproduce.

1. In 3-pane, select any message
2. View > Message Source (or CTRL+U)
3. In Source View windows, View > Character Encoding > (something different)

Reproduced on trunk, windows, linux. 

Firefox uses same source view window, but changing encoding does not cause error, so this is Thunderbird specific.
Status: UNCONFIRMED → NEW
Component: Untriaged → Mail Window Front End
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Version: 17 → Trunk
This error was also reported in Bug 779087
Problem was oberved in released Thunderbird 17.0. Not in trunk only. 
Alert shown by Tb 17.0 on Win-XP.
> [Javacrip Appliction]
> !  [... "Component returned failure code: 0x805e0006 [nsIWebNavigation.reload]"  nsresult:
>    "0x805e0006 (<unknown>)"  location: "JS frame :: chrome://global/content/bindings/browser.xml ::
>     reloadWithFlags :: line 103"  data: no]
>                                             [ OK ]
(Assignee)

Updated

5 years ago
Keywords: regression
(Assignee)

Comment 4

4 years ago
Created attachment 750548 [details] [diff] [review]
proposed fix
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #750548 - Flags: review?(mbanner)
Sorry for not responding here earlier. I think this is probably ok, though I'd like to dig into it a bit more.

As it changes the content policy, it definitely does need tests before we land it.
(Assignee)

Comment 6

4 years ago
Created attachment 793934 [details] [diff] [review]
bug814382_view_source_change_encoding_broken.patch

With tests.
Attachment #750548 - Attachment is obsolete: true
Attachment #750548 - Flags: review?(mbanner)
Attachment #793934 - Flags: review?(mbanner)
Comment on attachment 793934 [details] [diff] [review]
bug814382_view_source_change_encoding_broken.patch

Looks good, thanks.
Attachment #793934 - Flags: review?(mbanner) → review+
(Assignee)

Comment 8

4 years ago
https://hg.mozilla.org/comm-central/rev/448a69267a0c -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
(Assignee)

Comment 9

4 years ago
Comment on attachment 793934 [details] [diff] [review]
bug814382_view_source_change_encoding_broken.patch

Would be nice to see this make tb24.
Attachment #793934 - Flags: approval-comm-beta?
Attachment #793934 - Flags: approval-comm-aurora?
I'd love this for SeaMonkey's release as well. Mark?
Flags: needinfo?(mbanner)
Flags: needinfo?(mbanner)
Attachment #793934 - Flags: approval-comm-beta?
Attachment #793934 - Flags: approval-comm-beta+
Attachment #793934 - Flags: approval-comm-aurora?
Attachment #793934 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/a3574e532501
https://hg.mozilla.org/releases/comm-beta/rev/24b90b84740f
status-thunderbird24: --- → fixed
status-thunderbird25: --- → fixed
You need to log in before you can comment on or make changes to this bug.