Last Comment Bug 814382 - Can't change encoding for source view in TB17
: Can't change encoding for source view in TB17
: regression
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 26.0
Assigned To: Magnus Melin
Depends on:
  Show dependency treegraph
Reported: 2012-11-22 04:50 PST by Serg Iv
Modified: 2013-09-09 14:27 PDT (History)
6 users (show)
mkmelin+mozilla: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

proposed fix (1.90 KB, patch)
2013-05-16 11:05 PDT, Magnus Melin
no flags Details | Diff | Splinter Review
bug814382_view_source_change_encoding_broken.patch (5.91 KB, patch)
2013-08-22 02:59 PDT, Magnus Melin
standard8: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Serg Iv 2012-11-22 04:50:04 PST
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

1. Write something
2. Save to Draft
3. Click on message, press CTRL-U
4. Try to change encoding 

Actual results:

JS error message.
Please look here for the screenshot
Comment 1 User image David Lechner (:dlech) 2012-11-23 19:32:09 PST
This appears to affect all messages, not just drafts.

More specific steps to reproduce.

1. In 3-pane, select any message
2. View > Message Source (or CTRL+U)
3. In Source View windows, View > Character Encoding > (something different)

Reproduced on trunk, windows, linux. 

Firefox uses same source view window, but changing encoding does not cause error, so this is Thunderbird specific.
Comment 2 User image David Lechner (:dlech) 2012-11-23 19:52:20 PST
This error was also reported in Bug 779087
Comment 3 User image WADA:World Anti-bad-Duping Agency 2012-11-23 23:02:35 PST
Problem was oberved in released Thunderbird 17.0. Not in trunk only. 
Alert shown by Tb 17.0 on Win-XP.
> [Javacrip Appliction]
> !  [... "Component returned failure code: 0x805e0006 [nsIWebNavigation.reload]"  nsresult:
>    "0x805e0006 (<unknown>)"  location: "JS frame :: chrome://global/content/bindings/browser.xml ::
>     reloadWithFlags :: line 103"  data: no]
>                                             [ OK ]
Comment 4 User image Magnus Melin 2013-05-16 11:05:00 PDT
Created attachment 750548 [details] [diff] [review]
proposed fix
Comment 5 User image Mark Banner (:standard8) 2013-08-15 14:40:32 PDT
Sorry for not responding here earlier. I think this is probably ok, though I'd like to dig into it a bit more.

As it changes the content policy, it definitely does need tests before we land it.
Comment 6 User image Magnus Melin 2013-08-22 02:59:03 PDT
Created attachment 793934 [details] [diff] [review]

With tests.
Comment 7 User image Mark Banner (:standard8) 2013-08-28 06:35:47 PDT
Comment on attachment 793934 [details] [diff] [review]

Looks good, thanks.
Comment 8 User image Magnus Melin 2013-08-29 11:39:36 PDT -> FIXED
Comment 9 User image Magnus Melin 2013-08-29 11:52:24 PDT
Comment on attachment 793934 [details] [diff] [review]

Would be nice to see this make tb24.
Comment 10 User image Justin Wood (:Callek) [away until Feb 27] 2013-09-08 11:30:02 PDT
I'd love this for SeaMonkey's release as well. Mark?

Note You need to log in before you can comment on or make changes to this bug.