User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0.1 Build ID: 20120905151427 Steps to reproduce: 1. Write something 2. Save to Draft 3. Click on message, press CTRL-U 4. Try to change encoding Actual results: JS error message. Please look here for the screenshot http://forums.mozillazine.org/viewtopic.php?f=31&t=2620667
This appears to affect all messages, not just drafts. More specific steps to reproduce. 1. In 3-pane, select any message 2. View > Message Source (or CTRL+U) 3. In Source View windows, View > Character Encoding > (something different) Reproduced on trunk, windows, linux. Firefox uses same source view window, but changing encoding does not cause error, so this is Thunderbird specific.
This error was also reported in Bug 779087
Problem was oberved in released Thunderbird 17.0. Not in trunk only. Alert shown by Tb 17.0 on Win-XP. > [Javacrip Appliction] > ! [... "Component returned failure code: 0x805e0006 [nsIWebNavigation.reload]" nsresult: > "0x805e0006 (<unknown>)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: > reloadWithFlags :: line 103" data: no] > [ OK ]
Created attachment 750548 [details] [diff] [review] proposed fix
Sorry for not responding here earlier. I think this is probably ok, though I'd like to dig into it a bit more. As it changes the content policy, it definitely does need tests before we land it.
Created attachment 793934 [details] [diff] [review] bug814382_view_source_change_encoding_broken.patch With tests.
Comment on attachment 793934 [details] [diff] [review] bug814382_view_source_change_encoding_broken.patch Looks good, thanks.
Comment on attachment 793934 [details] [diff] [review] bug814382_view_source_change_encoding_broken.patch Would be nice to see this make tb24.
I'd love this for SeaMonkey's release as well. Mark?