814770 - Select Addresses blank if opened from Compose window with To/Cc/Bcc filled in

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

STR:
0. Ensure you have a mail account and contact(s) in the Personal Address Book
1. Open a Compose window (Ctrl+M)
2. Fill in at least one To, Cc or Bcc line
3. Click the Address icon or select Options/Select Addresses

Actual result: The list on the left (with headers Name, Email, Screen Name) is empty

Expected result: The list on the left shows your contacts. You will get this result if you have no (filled in) To, Cc or Bcc line in the Compose window.

Last known good: SM 2.13.2

First bad: 2.14b1

Nothing in the Error Console.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

It breaks here

http://mxr.mozilla.org/comm-central/source/suite/mailnews/addrbook/abSelectAddressesDialog.js#121

because gHeaderParser is undefined since bug 774069 removed it from abCommon.js.

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[[e-mail]]

Pushed comm-central changeset 90c30f23e058.

Comment 4

[[e-mail]]

Comment on attachment 684860 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 774069
User impact if declined: Can't edit existing addreses using dialog
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Comment 5

[[e-mail]]

https://hg.mozilla.org/releases/comm-aurora/rev/c181ca27c7fb
https://hg.mozilla.org/releases/comm-beta/rev/a47244f34da9

Comment 7

[Ian Neal]

Comment on attachment 684860 [details] [diff] [review]
Proposed patch

[Triage Comment]

Comment 8

[[e-mail]]

Comment on attachment 684860 [details] [diff] [review]
Proposed patch

https://hg.mozilla.org/releases/comm-release/rev/a44252ba0f5d