814936 - [system] use "…" instead of ".." in bluetooth transfer messages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Francesco Lodolo [:flod]]

apps\system\system.properties

bluetooth-sendingTitle=Sending Bluetooth transfer..
bluetooth-receivingTitle=Receiving Bluetooth transfer..
bluetooth-sending-progress=Sending Bluetooth transfer..
bluetooth-receiving-progress=Receiving Bluetooth transfer..

What are these ".."? Should it be a single dot "." for title or a "…" for progress? If not, why do we need duplicated strings?

kB=kB
I think that for English it should be KB, not kB (or at least it's KB everywhere else)

Comment 1

[Fernando Pereira Silveira]

kB is the correct one, since 'k' symbol (lowercase) stands for kilo-, which is a prefix denoting multiplication of the unit by one thousand.

'K' symbol (uppercase) stands for Kelvin, which is a unit of measurement for temperature.

Comment 2

[Fernando Pereira Silveira]

by the way, if we're talking about digital information units, which are multiplied by 1024 (not 1000), we should use 'kiB' according to IEC 60027.

http://en.wikipedia.org/wiki/Binary_prefix

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Fernando Pereira Silveira from comment #1)
> kB is the correct one, since 'k' symbol (lowercase) stands for kilo-, which
> is a prefix denoting multiplication of the unit by one thousand.

I kind of remember a bug about this, the point is that (AFAIK) all other products are using KB, not kB. I'm using kB myself for my lcoale, so I agree with you, but the point is also about consistency here.

A couple of examples

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/feeds/subscribe.properties#24

http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties#63

Comment 4

[Fernando Pereira Silveira]

I agree with you, consistency is important over all other products, so maybe 'KB' is the right choice, but in an ideal world, it *should* be 'kB' (or even better, 'kiB')

I also use 'kB' on pt-BR, which makes me wonder: what Mozilla and localizers think about 'kiB' and binary prefixes?

Comment 5

[Francesco Lodolo [:flod]]

Found in an old dev-l10n post about Fx 3.1

Bug 106618 and bug 420710

Comment 7

[Francesco Lodolo [:flod]]

Problem is still present in 1.2

Comment 8

[Francesco Lodolo [:flod]]

Most locales seem to be already using "…" instead of ".."
http://transvision.mozfr.org/string/?entity=apps/system/system.properties:bluetooth-sendingTitle&repo=gaia
While KB has been already fixed.

I don't think it's useful to use new key IDs at this point, every locale should have its own rules. CCing l10n alias to get a bit more visibility anyway.

Comment 9

[Francesco Lodolo [:flod]]

I can find the string -progress used and they're pretty easy to spot (just transfer a big file)
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/bluetooth_transfer.js#L336

But I can't find any reference to bluetooth-sendingTitle or bluetooth-receivingTitle, not even in the first landing of code
https://github.com/mozilla-b2g/gaia/commit/802bfc770ac1a884947cd93274d0a15457094507#diff-171571dcd7d2b8608173bb1b312b6e4e

Comment 10

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Not sure if :ianliu can be a reviewer, flagging him for feedback since it's the main contributor to that file.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8393368 [details] [review]
Pull request on Github

Thanks.

Comment 12

[[e-mail], [e-mail]]

Comment on attachment 8393368 [details] [review]
Pull request on Github

Thanks for your help. f+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/f454a2b1ded4afa8d88a3f782f7ba8a96d12ec10

Comment 14

[Francesco Lodolo [:flod]]

Verified on Keon, master git commit 3977de3c 2014-03-24