815011 - Appdir preferences are not being loaded for xpcshell tests on elm

Status: RESOLVED DUPLICATE of bug 810617

(Core :: XPConnect, defect)

Description

[Brian R. Bondy [:bbondy]]

Appdir preferences were not being loaded on elm causing app update xpcshell test errors.

I pushed an intermediate fix here, but I'm using this bug to see if we need a better fix.  The fix I did can be found here:
https://hg.mozilla.org/projects/elm/rev/80b11b866a11

Comment 1

[Brian R. Bondy [:bbondy]]

also in this followup changeset:
https://hg.mozilla.org/projects/elm/rev/da46872303a6

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 685010 [details] [diff] [review]
Patch v1

Bug 810617 is set to fix this in a much better way.

Comment 4

[Jim Mathies [:jimm]]

Yeah sorry I should have chatted with you about this in more details. I already went through a bunch of fixes in bug 810617, we settled on the (product)-appdir ini file fix. I'm looking at the remaining failures now.

Comment 5

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #2)
> Created attachment 685010 [details] [diff] [review]
> Patch v1

I'm doing a mc merge now. Will back this out with it so we can look at all the remaining app dir test failures.

Comment 6

[Brian R. Bondy [:bbondy]]

ok thanks, by the way the changeset contains more than just this so only undo these changes please Jim.

Comment 8

[Jim Mathies [:jimm]]

Actually we could have kept this one, I've filed bug 810617 on the xpcshell dir provider issue.

Comment 9

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #8)
> Actually we could have kept this one, I've filed bug 810617 on the xpcshell
> dir provider issue.

* bug 815256

Comment 10

[Brian R. Bondy [:bbondy]]

(In reply to Mike Hommey [:glandium] from comment #3)
> Comment on attachment 685010 [details] [diff] [review]
> Patch v1
> 
> Bug 810617 is set to fix this in a much better way.

Ah OK I was just going based on this comment. You can re-open if you want to take the bug.