815041 - [Social API] social.ambient-notification requires the contentPanel parameter

Status: RESOLVED DUPLICATE of bug 791615

(Firefox Graveyard :: SocialAPI, defect)

Description

[ANDO Yasushi]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1229.94 Safari/537.4

Steps to reproduce:

I sent the social.ambient-notification message from a worker without the contentPanel parameter.


Actual results:

https://github.com/mozilla/socialapi-dev/blob/develop/docs/socialAPI.md

The document above says that the contentPanel parameter for the social.ambient-notification message is optional but the notification button made by the message without the param opens a panel with an error message, "Nightly is unable to connect with [sidebar name] right now."


Expected results:

I expect that sending the social.ambient-notification message without the contentPanel param makes the notification button unclickable.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Right now the "ambient notification" code assumes that you'll want to open a panel. What would you like your button to do instead, when clicked?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

See also bug 791615, which calls for a way a provider can request an icon be removed.

Comment 3

[ANDO Yasushi]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #1)
> Right now the "ambient notification" code assumes that you'll want to open a
> panel. 

Does the fact mean the contentPanel parameter is mandatory? If so, I'm ok but perhaps you should modify socialAPI.md.

> What would you like your button to do instead, when clicked?

I'd like the button just to ignore mouse-clicking when there is no information to notify.

Comment 4

[ANDO Yasushi]

(In reply to Mark Hammond (:markh) from comment #2)
> See also bug 791615, which calls for a way a provider can request an icon be
> removed.

Thanks, the issue also accords with my hope.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

I modified socialAPI.md even though we are trying to move this info to the wiki.  We do need to do more in the way of docs :(

Based on comment 4, I'll close this as a dupe.

Comment 6

[ANDO Yasushi]

OK, thanks.