815206 - [homescreen] displays a confirmation and restarts a failed download

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Julien Wajsberg [:julienw]]

In Bug 802596, we want to restart a failed Webapp installation.

- homescreen displays the confirmation screen to the user
- homescreen calls |download| on the app object

Comment 1

[Julien Wajsberg [:julienw]]

Nominating BB+ because depending Bug 802596 is BB+

Comment 2

[Dietrich Ayala (:dietrich)]

Francisco, how long do you estimate it will take for your fix for this?

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Dietrich, hopefully the end of this week.

Comment 4

[Julien Wajsberg [:julienw]]

Josh, we need your wisdom here.

When the user accepts the restart confirmation, nothing changes on the homescreen until the first progress event is sent (ie until the first data is received).

What it means is that on a shitty network (like right now) the user would not have any notification that something happens. Moreover as nothing changed, he could still tap on the icon and would have the same restart confirmation window.

My view is that the icon should change as soon as the user accepts the restart and not react to taps anymore.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to GitHub PR 6722

Please note that we are still pending Bug 815206 from platform to land.

Comment 6

[Dietrich Ayala (:dietrich)]

(In reply to Francisco Jordano [:arcturus] from comment #5)
> Please note that we are still pending Bug 815206 from platform to land.

Nice try. I only clicked through that cycle 32 times before catching on.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Dietrich Ayala (:dietrich) from comment #6)
> (In reply to Francisco Jordano [:arcturus] from comment #5)
> > Please note that we are still pending Bug 815206 from platform to land.
> 
> Nice try. I only clicked through that cycle 32 times before catching on.

LoL:

I mean, it's pending

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Francisco Jordano [:arcturus] from comment #7)
> (In reply to Dietrich Ayala (:dietrich) from comment #6)
> > (In reply to Francisco Jordano [:arcturus] from comment #5)
> > > Please note that we are still pending Bug 815206 from platform to land.
> > 
> > Nice try. I only clicked through that cycle 32 times before catching on.
> 
> LoL:
> 
I mean, it's pending 815547, it's a nice trick, will use it often.

Tried the platform patch locally and is looking good :) with this + the changes that Julien did to the system app

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 686706 [details]
Pointer to GitHub PR 6722

reviewed on github, didn't try the patch yet

I don't know how the homescreen works so take my comments as suggestions and not as hard problems.

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 686706 [details]
Pointer to GitHub PR 6722

found a blocker: the icon is not updated when we receive a downloaderror or downloadsuccess after a restart.

Comment 11

[Julien Wajsberg [:julienw]]

and we still need Josh's answer...

Comment 12

[Josh Carpenter [:jcarpenter]]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> My view is that the icon should change as soon as the user accepts the
> restart and not react to taps anymore.

Agreed. Correct me if I'm wrong, but we're talking about a programming change that is required in order to ensure faithfulness to the spec?

Comment 13

[Julien Wajsberg [:julienw]]

(In reply to Josh Carpenter [:jcarpenter] from comment #12)
> 
> Agreed. Correct me if I'm wrong, but we're talking about a programming
> change that is required in order to ensure faithfulness to the spec?

Yep (but the spec was not so clear about this).

Thanks !

Comment 14

[Julien Wajsberg [:julienw]]

Francisco> what do you think about landing this bug without Josh's changes, and opening a new bug for tracking this ?

Or do you want to do it all at once ?

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

:julienw i'm adding the changes, when the user clicks we will show the spinner.

Right now just testing the edge cases, will ping you for a second review.

Thanks a lot!

Comment 16

[Julien Wajsberg [:julienw]]

Comment on attachment 686706 [details]
Pointer to GitHub PR 6722

let's do a follow up for apps with more than one entry point because I think we'll have some visual problems (although the feature should still work).

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Thanks, definitely we need a follow up for all the weird cases that we could find.

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Landed

https://github.com/mozilla-b2g/gaia/pull/6722