815547 - [Apps] Inconsistent app attribute status when download error

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

Currently we have two ways of receiving a 'downloadError', in both we find some inconsistences.

- By calling app.cancelDownload:
    -> Hosted App: (looking good)
        -> app.installState: pending
        -> app.downloading: false
    -> Packaged App: (looking not that good)
        -> app.installState: pending
        -> app.downloading: *true*

- By network error:
    -> Hosted App: (looking good)
        -> app.installState: pending
        -> app.downloading: false
    -> Packaged App: (looking not that good)
        -> app.installState: *undefined*
        -> app.downloading: false

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: wip2

I can confirm that the previous patch works. I only added the fix for packaged apps error due to connection errors.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v3

More apps state love.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 686501 [details] [diff] [review]
v3

Review of attachment 686501 [details] [diff] [review]:
-----------------------------------------------------------------

I hate this code more and more. It's time for a state machine based rewrite...

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2fb47b6278

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d2fb47b6278

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e8e4384f925a
https://hg.mozilla.org/releases/mozilla-beta/rev/da8822dd0181