815295 - Disable the Downloads Panel in Firefox 19

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We'll want to disable this about a week or two before the next merge (which is currently scheduled during the week of 2013-01-06).

So basically, we should shut this off on Aurora just before the holidays start.

Comment 1

[Marco Bonardo [:mak]]

The patch is the same used to disable in 18 (thus added dependency)

Comment 2

[Marco Bonardo [:mak]]

We should do this just before the christmas holidays, the next merge is on 7th jan, so that looks like about the requested 2-weeks-before-merge.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Disable the Downloads Panel in Aurora 19

Comment 4

[Marco Bonardo [:mak]]

This should land before Friday.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Marco Bonardo [:mak] from comment #4)
> This should land before Friday.

This applies cleanly for me. Does this need an r+, or should I just request approval for mozilla-aurora?

Comment 6

[Marco Bonardo [:mak]]

just get approval, this went through enough landings already to required further reviews :)

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 688887 [details] [diff] [review]
Disable the Downloads Panel in Aurora 19

As Aurora 19 approaches the uplift, we want to disable the Downloads Panel, since we only left it enabled on Aurora for testing.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
N/A

User impact if declined: 
Users get a half-baked Downloads Panel experience in Beta.

Testing completed (on m-c, etc.):
This patch has been used to disable the Panel at least two other times - seems to work well.

Risk to taking this patch (and alternatives if risky): 
None.

String or UUID changes made by this patch: 
None.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8d77162e2613

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Followup to disable browser_first_download_panel.js, which was timing out.
https://hg.mozilla.org/releases/mozilla-aurora/rev/85d4b438e27d

Comment 10

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 19 beta 1 - the downloads panel is disabled (per default the preference browser.download.useToolkitUI is set to true in about:config).

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.8.2:
Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/20100101 Firefox/19.0
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/20100101 Firefox/19.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0

Comment 11

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old