815366 - Implement "Old-style, undocumented services" into middleware_app.py

Status: RESOLVED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[Peter Bengtsson [:peterbe]]

middleware_app.py only ported URLs that were documented on http://socorro.readthedocs.org/en/latest/middleware.html but not the 
"Old-style, undocumented services" ones on
http://socorro.readthedocs.org/en/latest/middleware.html#old-style-undocumented-services

We should only port those that are actually going to be used by socorro-crashstats.

Comment 1

[Laura Thomson :laura]

This blocks deployment, because the PHP app depends on at least one of those services.  The PHP app will be around into Q1 next year (hope to turn it off sometime during that quarter), so you can either port the services that it uses, or wait on the new mware.

Comment 2

[Peter Bengtsson [:peterbe]]

After "grepping around" in models.py, the only services we're using are:

1. /topcrash/sig/trend/history
2. /current/versions

(surprising that we're using /topcrash/sig/trend/history but not /topcrash/sig/trend/rank)

Comment 3

[Peter Bengtsson [:peterbe]]

(In reply to Laura Thomson :laura from comment #1)
> This blocks deployment, because the PHP app depends on at least one of those
> services.  The PHP app will be around into Q1 next year (hope to turn it off
> sometime during that quarter), so you can either port the services that it
> uses, or wait on the new mware.

Last time rhelmer and talked about it we decided it's best to stagger it so socorro-crashstats blocks middleware_app.

Right, Rob?

So there's not much rush on this bug right now.

Comment 4

[Peter Bengtsson [:peterbe]]

:rhelmer has said we won't use the /current/versions in socorro-crashstats. Instead, I believe, we're going to use /products

I guess it just leaves the  /topcrash/sig/trend/history to have to be re-implemented as a new middleware service.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

I don't think it was done, so getCrash (/crash) also has to be ported to a new style service. I can do it as part of bug 815309.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

To make things clear about the /crash service: there are currently two /crash services, one is an old one (it uses HBase, and has a different URL scheme) and the other is a new one (uses only postgres). The old one needs to be merged into the new one, and there is a bug for that, bug 800177. I assigned that bug to myself and am currently working on it.

Comment 7

[Peter Bengtsson [:peterbe]]

All old-style services were moved in middleware_app.py a long time ago.