815545 - Social API removal does nothing, silently schedules removal on restart

Status: RESOLVED DUPLICATE of bug 813436

(Firefox Graveyard :: SocialAPI, defect)

Description

[Dirkjan Ochtman (:djc)]

I enabled the Facebook social API in 18.0a2, then removed it from the toolbar to get rid of it. When upgrading to 19, a button returned to my navigation toolbar. Clicking it provided a "Remove from Aurora", clicking that popped up a modal dialog asking for confirmation. Clicking the button to confirm the removal did not result in the removal of the Facebook button from the nav toolbar; it looked like nothing had happened. On restart, the button was gone.

- Clicking the remove button on the modal dialog should remove the button from the nav toolbar immediately. If Firefox can do restartless addons, I'm sure the Social API stuff can be implemented as something that can be removed without restart.

- If the button removal cannot be done without restart, a notification of the required restart should be given *after* confirming the removal in the modal dialog. Confirming the removal without reading the modal dialog (whose utility I would doubt) is way too easy.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Hi Dirkjan - thanks! This sounds very much like bug 813436 - hopefully will get to 19 in a few days.  The social api certainly is designed to be totally restartless but that bug does leave a few artifacts around (including the toolbar, even though it only mentions menus)