815561 - Limit Web Activities to the foreground application

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[:fabrice] Fabrice Desré]

See rationale in bug 794407.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 2

[Mounir Lamouri (:mounir)]

Before landing this, can we have an idea of what broke, what has been fixed, what needs to be fixed, what can be fixed and how dirty the workarounds are? Having no user interaction requirement is security-wise scary *and* we will break content when we will add the requirement (because, really, we need something).

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'd rather not block fixing these regressions any longer. The patch in bug 794407 should have been backed out a lot sooner given the number of regressions it caused.

We can always audit what broke even with this patch landed.

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99b74e86c185

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/99b74e86c185

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d9e61a46b2d
https://hg.mozilla.org/releases/mozilla-beta/rev/e3653f4e9fc0

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 685533 [details] [diff] [review]
patch

Review of attachment 685533 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/activities/src/Activity.cpp
@@ +52,5 @@
>    NS_ENSURE_TRUE(window, NS_ERROR_UNEXPECTED);
>  
>    Init(window);
>  
> +  nsCOMPtr<nsIDocument> document = do_QueryInterface(window->GetExtantDoc());

Useless QI