815689 - HTML composition broken with nightly 20121127

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[u331436]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 SeaMonkey/2.17a1
Build ID: 20121127003038

Steps to reproduce:

compose a new Email (setting on most of my accounts to compose in HTML)


Actual results:

Email composition is not HTML but ASCI.


Expected results:

Composition should be in HTML.

Comment 1

[u331436]

This problem appears on each account that is configured for HTML composition.
Add-on installed: Lightning, Exchange Calendar, Adblock+, Noscript, French Dictionary. Will try in safe mode and report

Comment 2

[u331436]

Same problem in Safe Mode, regression between 20121126 and 20121127.

Comment 3

[u331436]

Some more investigations:
- Setting an account with "plain text" message composition brings HTML composition when clicking "compose" then HTML or Plain text (same result in both cases).
- Setting an account with "HTML msg composition" bring plain text composition when clicking "compose" and then HTML or Plain text (same result in both cases).

Really strange. I wonder if my profile is corrupted.... Will try a test profile

Comment 4

[u331436]

Same with a test profile

Comment 5

[therube]

Mozilla/5.0 (Windows NT 5.1; rv:20.0) Gecko/20.0 Firefox/20.0 SeaMonkey/2.17a1
Build identifier: 20121127003038

What I see with 1127 is that the Compose /button/ opens a compose window in the format that is selected Account Settings.

So if HTML is set in Account Settings, you get HTML & if deselected, you get text - with the Button.

The dropdown selector on the Compose button gives you the inverse of the setting selected in Account Settings, regardless of which option is chosen.

If HTML is set in Account Settings, the dropdown selector gives you Text - all the time.

If HTML is not set in Account Settings, the dropdown selector gives you HTML - all the time.
 
 
(SeaMonkey 2.16 looks to work correctly.  I have no other 2.17 builds.)

Comment 6

[u331436]

Correction: I find the regression window between 20121125 (good) and 20121126 (bad) and 20121127 ( bad as well).

therube: Your description is just fine.

Comment 7

[Philip Chee]

The only patch that touches message composition in this range is Bug 811117 (Remove GetSelectedMessages from mail window and refactor some mail window code) Although I can't see what in that patch could cause this.

Comment 8

[Philip Chee]

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2012-11-25&enddate=2012-11-27

Comment 9

[u331436]

confirmed the narrowing of the the regression window between the 20121125 nightly (good)and 20121126 nightly (bad). 
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2012-11-25&enddate=2012-11-26

Comment 10

[Ian Neal]

Attachment: Fix missing brackets and format conversion [Checked in: Comment 12]

This fixes some missing brackets which caused an issue when overriding the format and also has MsgNewMessage pass the format number rather the format name to ComposeMsgByType

Comment 11

[Karsten Düsterloh]

Comment on attachment 686061 [details] [diff] [review]
Fix missing brackets and format conversion [Checked in: Comment 12]

Oops.

Comment 12

[Ian Neal]

Comment on attachment 686061 [details] [diff] [review]
Fix missing brackets and format conversion [Checked in: Comment 12]

http://hg.mozilla.org/comm-central/rev/9d64c5dc1983

Comment 13

[Philip Chee]

Is there anything more to do here? Can we close this now?