Closed Bug 815689 Opened 9 years ago Closed 9 years ago

HTML composition broken with nightly 20121127

Categories

(SeaMonkey :: MailNews: Composition, defect)

defect
Not set
major

Tracking

(seamonkey2.17 fixed)

RESOLVED FIXED
seamonkey2.17
Tracking Status
seamonkey2.17 --- fixed

People

(Reporter: u331436, Assigned: iannbugzilla)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 SeaMonkey/2.17a1
Build ID: 20121127003038

Steps to reproduce:

compose a new Email (setting on most of my accounts to compose in HTML)


Actual results:

Email composition is not HTML but ASCI.


Expected results:

Composition should be in HTML.
This problem appears on each account that is configured for HTML composition.
Add-on installed: Lightning, Exchange Calendar, Adblock+, Noscript, French Dictionary. Will try in safe mode and report
Same problem in Safe Mode, regression between 20121126 and 20121127.
Severity: normal → major
Keywords: regression
Some more investigations:
- Setting an account with "plain text" message composition brings HTML composition when clicking "compose" then HTML or Plain text (same result in both cases).
- Setting an account with "HTML msg composition" bring plain text composition when clicking "compose" and then HTML or Plain text (same result in both cases).

Really strange. I wonder if my profile is corrupted.... Will try a test profile
Same with a test profile
Mozilla/5.0 (Windows NT 5.1; rv:20.0) Gecko/20.0 Firefox/20.0 SeaMonkey/2.17a1
Build identifier: 20121127003038

What I see with 1127 is that the Compose /button/ opens a compose window in the format that is selected Account Settings.

So if HTML is set in Account Settings, you get HTML & if deselected, you get text - with the Button.

The dropdown selector on the Compose button gives you the inverse of the setting selected in Account Settings, regardless of which option is chosen.

If HTML is set in Account Settings, the dropdown selector gives you Text - all the time.

If HTML is not set in Account Settings, the dropdown selector gives you HTML - all the time.
 
 
(SeaMonkey 2.16 looks to work correctly.  I have no other 2.17 builds.)
Correction: I find the regression window between 20121125 (good) and 20121126 (bad) and 20121127 ( bad as well).

therube: Your description is just fine.
The only patch that touches message composition in this range is Bug 811117 (Remove GetSelectedMessages from mail window and refactor some mail window code) Although I can't see what in that patch could cause this.
confirmed the narrowing of the the regression window between the 20121125 nightly (good)and 20121126 nightly (bad). 
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2012-11-25&enddate=2012-11-26
Assignee: nobody → iann_bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
This fixes some missing brackets which caused an issue when overriding the format and also has MsgNewMessage pass the format number rather the format name to ComposeMsgByType
Attachment #686061 - Flags: review?(mnyromyr)
Comment on attachment 686061 [details] [diff] [review]
Fix missing brackets and format conversion [Checked in: Comment 12]

Oops.
Attachment #686061 - Flags: superreview+
Attachment #686061 - Flags: review?(mnyromyr)
Attachment #686061 - Flags: review+
Comment on attachment 686061 [details] [diff] [review]
Fix missing brackets and format conversion [Checked in: Comment 12]

http://hg.mozilla.org/comm-central/rev/9d64c5dc1983
Attachment #686061 - Attachment description: Fix missing brackets and format conversion → Fix missing brackets and format conversion [Checked in: Comment 12]
Is there anything more to do here? Can we close this now?
Flags: needinfo?(iann_bugzilla)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
Flags: needinfo?(iann_bugzilla)
You need to log in before you can comment on or make changes to this bug.