815718 - Disable PDF.js In FF18 Beta

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: disable pdf.js in beta 18

[Approval Request Comment]
User impact if declined: pdf.js will be enabled in FF18, which doesn't have pdf.js blockers fixed
Testing completed (on m-c, etc.): same patch has been landed before (bug 773397)
Risk to taking this patch (and alternatives if risky): none 
String or UUID changes made by this patch: none

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 685733 [details] [diff] [review]
disable pdf.js in beta 18

This is the same patch as for other disablings, right? Shouldn't need review then.

Comment 3

[Brendan Dahl [:bdahl]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #2)
> Comment on attachment 685733 [details] [diff] [review]
> disable pdf.js in beta 18
> 
> This is the same patch as for other disablings, right? Shouldn't need review
> then.
Yeah, same as https://bugzilla.mozilla.org/show_bug.cgi?id=773397#c9 , just rebased to make sure it applied cleanly.

Comment 4

[Brendan Dahl [:bdahl]]

Comment on attachment 685733 [details] [diff] [review]
disable pdf.js in beta 18

Review of attachment 685733 [details] [diff] [review]:
-----------------------------------------------------------------

Patch previously submitted in https://bugzilla.mozilla.org/show_bug.cgi?id=773397#c9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/afcad892d8bf

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Verified that PDFjs is disabled on beta branch (Firefox 18 beta 4) on all main platforms (Mac 10.7.5, Ubuntu 12.04, Win 7) and the Preview in Firefox option is not available for opening PDFs.