Closed Bug 816114 Opened 7 years ago Closed 7 years ago

Awesomebar tabs vanish when using a dark/complex lightweight theme

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 20
Tracking Status
firefox19 --- verified
firefox20 --- verified

People

(Reporter: deb, Assigned: sriram)

References

Details

Attachments

(3 files)

Noticed this in Nightly yesterday, but the non-focused new tab tabs (bookmarks, history, top sites) vanish when you have installed a dark lightweight theme (aka: Persona).

Screenie attached.
OS: Mac OS X → Android
Product: Fennec → Firefox for Android
Hardware: x86 → ARM
Assignee: nobody → sriram
I'm about to start working on text-colors for persona. Will post patches soon.
(In reply to Sriram Ramasubramanian [:sriram] from comment #1)
> I'm about to start working on text-colors for persona. Will post patches
> soon.

Sriram, so no need yet to file another bug on about:home being hard to read on dark themes?
The tab text colors aren't straightforward as the about:home colors. On about:home, most of the text that needs a change in their color are over a solid background. In this case, these texts are usually over an image. We should probably use the approach used in desktop -- applying a small little text shadow (the text color will be like about:home though).
Flags: needinfo?(ibarlow)
Summary: New tab tabs vanish when using a dark/complex lightweight theme → Awesomebar tabs vanish when using a dark/complex lightweight theme
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #2)
> (In reply to Sriram Ramasubramanian [:sriram] from comment #1)
> > I'm about to start working on text-colors for persona. Will post patches
> > soon.
> 
> Sriram, so no need yet to file another bug on about:home being hard to read
> on dark themes?

Filed bug 822421 for the same.
(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> Filed bug 822421 for the same.

Thanks, I've also noticed that the dark icons on the toolbar are also not too easy to see on the dark theme I'm using - I guess that might need a similar solution to the tab text colors and have some kind of light shadow applied that isn't very visible on default background or light themes but makes them stand out on a dark theme. FYI, I'm using https://www.getpersonas.com/en-US/persona/148113 but I guess any dark theme works for testing those things.
As a first step, Sriram and I talked about flipping the textcolor based on the dominant persona color _and_ adding a slight text shadow. But only adding the text shadow when a persona is active. No persona, no text shadow.
Attached patch PatchSplinter Review
The text color changes based on the themes.
Attachment #695040 - Flags: review?(mark.finkle)
Attachment #695040 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/869f370625c6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
[Approval Request Comment]
Bug caused by (feature/regressing bug #): New design spec.
User impact if declined: Awesomebar tabs text color will be black for dark themes.
Testing completed (on m-c, etc.): Landed in m-c on 12/29
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.

(This patch adds a new file for the color -- as that was previously added for private browsing -- which aurora doesn't have. Some code cleanup in styleSelectedTab() as we don't the bits-n-bytes related to private browsing).
Attachment #696800 - Flags: approval-mozilla-aurora?
Comment on attachment 696800 [details] [diff] [review]
Patch: Aurora ready

low risk fix for a new feature landed in FF19.A win for users who use dark lightweight theme.
Attachment #696800 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tested with: Nebula Streaks, Black_Sun_2013 and Full Black Moon personas on Nightly 21.0a1 2013-01-10, Dark Fox 7 Lite, Ffoxglow and lord_of_the_rings personas on Aurora 20.0a2 2013-01-10, Disturbed, Animated Secluded Mountain Christmas and Blue Fractal 2 personas on Firefox Mobile 19 beta 1. In all cases the inactive tabs text was correctly displayed on the HTC Desire Z (Android 2.3.3)
Status: RESOLVED → VERIFIED
Flags: needinfo?(ibarlow)
You need to log in before you can comment on or make changes to this bug.