816333 - Bug IDs in the "Change Votes" page are no longer linkified

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Alice0775 White]

This problem happens since few days ago.

Str
Open Voting page

Actual results:
No link to individual bug#

Expected  results:
Bug# should be link to the bug

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Confirming. This must have happened 1-2 days ago.

Comment 2

[:glob ✱]

this is caused by bug 811280 (which was backported to bmo in bug 814411).

the voting extension passes in a bug object from the template to get_bug_link, which isn't expected because it isn't blessed (it's a hashref).

Comment 3

[:glob ✱]

Attachment: patch v1

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 686980 [details] [diff] [review]
patch v1

Review of attachment 686980 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me r=dkl

Comment 5

[Frédéric Buclin]

Comment on attachment 686980 [details] [diff] [review]
patch v1

>-            $bug = new Bugzilla::Bug({ id => $bug, cache => 1 });
>+            $bug = new Bugzilla::Bug({ id => ref($bug) ? $bug->{id} : $bug,
>+                                       cache => 1 });

(In reply to Byron Jones ‹:glob› from comment #2)
> the voting extension passes in a bug object from the template to
> get_bug_link, which isn't expected because it isn't blessed (it's a hashref).

"which isn't expected" means that the Voting extension should be fixed instead. Else this means that you can pass either a bug ID, or a bug hashref or a bug object to get_bug_link(). This looks like a pretty bad design. We should only pass a bug object or a bug ID.

You should rather fix extensions/Voting/template/en/default/pages/voting/user.html.tmpl and replace

  [% bug.id FILTER bug_link(bug) FILTER none %]

by

  [% bug.id FILTER bug_link(bug.id) FILTER none %]

I don't want to change how a core method works just because an extension is unable to pass expected arguments.

Comment 6

[Frédéric Buclin]

The culprit is not the cache used by Bugzilla::Object. It's the Voting extension which doesn't pass expected arguments to bug_link().

Comment 7

[:glob ✱]

Attachment: patch v2

this revision updates the voting extension only.

Comment 8

[:glob ✱]

relnote: currently extensions can pass in a bug "object" from a template to get_bug_link.  with this change they will have to provide bug.id instead.

Comment 9

[Frédéric Buclin]

Comment on attachment 687650 [details] [diff] [review]
patch v2

>=== modified file 'extensions/Voting/template/en/default/pages/voting/bug.html.tmpl'

>-  [% "$terms.Bug $bug.id" FILTER bug_link(bug) FILTER none %] - [% bug.short_desc FILTER html %]
>+  [% "$terms.Bug $bug.id" FILTER bug_link(bug.id) FILTER none %] - [% bug.short_desc FILTER html %]

This change is not needed. This template gets a real Bugzilla::Bug object, so this is fine. Only voting/user.html.tmpl must be fixed.


r=LpSolit with this change reverted.

Comment 10

[Frédéric Buclin]

(In reply to Byron Jones ‹:glob› from comment #8)
> relnote: currently extensions can pass in a bug "object" from a template to
> get_bug_link.  with this change they will have to provide bug.id instead.

A Bugzilla::Bug object is fine. What is not fine is a hash trying to simulate a bug object by having id as key.

Comment 11

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified extensions/Voting/template/en/default/pages/voting/user.html.tmpl
Committed revision 8506.

Comment 12

[(mostly gone) XtC4UaLL [:xtc4uall]]

This is considered being pushed on the weekly(?) BMO Pushday, right? :)

Comment 13

[David Lawrence [:dkl]]

(In reply to XtC4UaLL [:xtc4uall] from comment #12)
> This is considered being pushed on the weekly(?) BMO Pushday, right? :)

Yep. It will be included in the next BMO code push later this week.

http://bzr.mozilla.org/bmo/4.0/revision/8408

dkl