Backport Bug 811280 and Bug 815026 to BMO (Add a caching mechanism to Bugzilla::Object to avoid querying the database repeatedly for the same information)

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 684444 [details] [diff] [review]
patch v1

i'd like to get a sanity check on this before i commit.

in addition to the backport, i've also added cache tags to extensions where appropriate.
Attachment #684444 - Flags: review?(dkl)
(Assignee)

Comment 2

5 years ago
Comment on attachment 684444 [details] [diff] [review]
patch v1

i'll attach an updated patch soon which fixes the shadowbugs issue, and also incorporates the patch from bug 815026
Attachment #684444 - Attachment is obsolete: true
Attachment #684444 - Flags: review?(dkl)
(Assignee)

Updated

5 years ago
Summary: Backport Bug 811280 to BMO (Add a caching mechanism to Bugzilla::Object to avoid querying the database repeatedly for the same information) → Backport Bug 811280 and Bug 815026 to BMO (Add a caching mechanism to Bugzilla::Object to avoid querying the database repeatedly for the same information)
(Assignee)

Comment 3

5 years ago
Created attachment 685130 [details] [diff] [review]
patch v2
Attachment #685130 - Flags: review?(dkl)
Comment on attachment 685130 [details] [diff] [review]
patch v2

Review of attachment 685130 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works well in my testing. r=dkl
Attachment #685130 - Flags: review?(dkl) → review+
(Assignee)

Comment 5

5 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified attachment.cgi
modified show_bug.cgi
modified Bugzilla/Attachment.pm
modified Bugzilla/Bug.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Object.pm
modified Bugzilla/Product.pm
modified Bugzilla/Template.pm
modified extensions/BMO/Extension.pm
modified extensions/InlineHistory/Extension.pm
modified extensions/Splinter/Extension.pm
modified extensions/Splinter/lib/Util.pm
Committed revision 8402.

will leave this bug open and work on the 4.2 port (which is just about the fixing patch offsets).
(Assignee)

Comment 6

5 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified attachment.cgi
modified show_bug.cgi
modified Bugzilla/Attachment.pm
modified Bugzilla/Bug.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Object.pm
modified Bugzilla/Product.pm
modified Bugzilla/Template.pm
modified extensions/BMO/Extension.pm
modified extensions/InlineHistory/Extension.pm
modified extensions/Splinter/Extension.pm
modified extensions/Splinter/lib/Util.pm
Committed revision 8432.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 816333

Updated

5 years ago
No longer blocks: 816333
You need to log in before you can comment on or make changes to this bug.