814411 - Backport Bug 811280 and Bug 815026 to BMO (Add a caching mechanism to Bugzilla::Object to avoid querying the database repeatedly for the same information)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Comment 1

[:glob ✱]

Attachment: patch v1

i'd like to get a sanity check on this before i commit.

in addition to the backport, i've also added cache tags to extensions where appropriate.

Comment 2

[:glob ✱]

Comment on attachment 684444 [details] [diff] [review]
patch v1

i'll attach an updated patch soon which fixes the shadowbugs issue, and also incorporates the patch from bug 815026

Comment 3

[:glob ✱]

Attachment: patch v2

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 685130 [details] [diff] [review]
patch v2

Review of attachment 685130 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works well in my testing. r=dkl

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified attachment.cgi
modified show_bug.cgi
modified Bugzilla/Attachment.pm
modified Bugzilla/Bug.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Object.pm
modified Bugzilla/Product.pm
modified Bugzilla/Template.pm
modified extensions/BMO/Extension.pm
modified extensions/InlineHistory/Extension.pm
modified extensions/Splinter/Extension.pm
modified extensions/Splinter/lib/Util.pm
Committed revision 8402.

will leave this bug open and work on the 4.2 port (which is just about the fixing patch offsets).

Comment 6

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified attachment.cgi
modified show_bug.cgi
modified Bugzilla/Attachment.pm
modified Bugzilla/Bug.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Object.pm
modified Bugzilla/Product.pm
modified Bugzilla/Template.pm
modified extensions/BMO/Extension.pm
modified extensions/InlineHistory/Extension.pm
modified extensions/Splinter/Extension.pm
modified extensions/Splinter/lib/Util.pm
Committed revision 8432.