816375 - Switch NodeFilter to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This mostly just affects what sort of object Window.NodeFilter returns

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Switch NodeFilter to WebIDL bindings.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 686401 [details] [diff] [review]
Switch NodeFilter to WebIDL bindings.

Review of attachment 686401 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +1145,5 @@
>          #       We should be able to check for special operations without an
>          #       identifier. For now we check if the name starts with __
> +
> +        # Ignore non-static methods for callback interfaces
> +        if not descriptor.interface.isCallback() or static:

I guess it's a little hard to make us never get here if descriptor.interface.isCallback() and not static?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I guess it's a little hard to make us never get here if descriptor.interface.isCallback()
> and not static?

We could do it, but it would complicate a bunch of code further up that would have to deal with PropertyArrays.methods sometimes existing and sometimes not existing....

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c833cab38b08

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c833cab38b08