Closed Bug 816375 Opened 7 years ago Closed 7 years ago

Switch NodeFilter to WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This mostly just affects what sort of object Window.NodeFilter returns
Depends on: 816376
Comment on attachment 686401 [details] [diff] [review]
Switch NodeFilter to WebIDL bindings.

Review of attachment 686401 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +1145,5 @@
>          #       We should be able to check for special operations without an
>          #       identifier. For now we check if the name starts with __
> +
> +        # Ignore non-static methods for callback interfaces
> +        if not descriptor.interface.isCallback() or static:

I guess it's a little hard to make us never get here if descriptor.interface.isCallback() and not static?
Attachment #686401 - Flags: review?(peterv) → review+
> I guess it's a little hard to make us never get here if descriptor.interface.isCallback()
> and not static?

We could do it, but it would complicate a bunch of code further up that would have to deal with PropertyArrays.methods sometimes existing and sometimes not existing....
https://hg.mozilla.org/integration/mozilla-inbound/rev/c833cab38b08
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/c833cab38b08
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.