816376 - Interface objects for callback interfaces should not be functions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per spec, these should be just vanilla objects, whose proto is Object.prototype.  Right now we create a callable object whose proto is Function.prototype.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Create vanilla objects for the interface object of callback interfaces.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 686389 [details] [diff] [review]
Create vanilla objects for the interface object of callback interfaces.

Review of attachment 686389 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +1465,1 @@
>          constructHook = "&" + CONSTRUCT_HOOK_NAME + "_holder"

I know you're just changing existing code, but needConstructor seems badly named here :-/. I think it would make more sense to rename needsConstructorFunction to needsConstructHookHolder or something and do:

        if (needInterfaceObject and
            self.descriptor.needsConstructHookHolder():
            constructHookHolder = "&" + CONSTRUCT_HOOK_NAME + "_holder"
        else:
            constructHookHolder = "nullptr"

and pass that in to the call to CreateInterfaceObjects.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d531b6a61a6e with that change.  Once we turn on WebIDL bindings for NodeFilter this will be tested too (that's how I found it).

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d531b6a61a6e