816408 - Add ability to specify promptWaitTime (added in bug 813322) in the update snippets

Status: RESOLVED FIXED

(AUS Graveyard :: API, defect, P2)

Description

[Robert Strong (they/them - no direct email)]

+++ This bug was initially created as a clone of Bug #813322 +++

Currently we prompt to apply update after 24 hours of continuous use. This would allow us to override the time interval remotely.

The new xml attribute name for controlling this is promptWaitTime and the value is the number of seconds to wait before prompting to restart. The name was chosen so it matches with the app.update.promptWaitTime preference and the value is in seconds so it matches the preference's value.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Do we have a specific release we're targeting to use this, or is the timeline more open ended ?

Comment 2

[Robert Strong (they/them - no direct email)]

It is on the train for Firefox 20 but akeybl has asked if it would be ok to uplift this to aurora for Firefox 19 so likely Firefox 19.

Comment 3

[Alex Keybl [:akeybl]]

(In reply to Robert Strong [:rstrong] (do not email) from comment #2)
> It is on the train for Firefox 20 but akeybl has asked if it would be ok to
> uplift this to aurora for Firefox 19 so likely Firefox 19.

Yep - would be great if we could start utilizing this in the FF19 beta timeframe (starting 1/6), in preparation for that release.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Nick - is this your bug?  Wondering what needs to be prepared/tested in advance of the merge to beta.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

I should be able to get this done before Christmas.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [cvs] Support promptWaitTime in snippets

rhelmer, this is the standard boilerplate for adding a new attribute to the update.xml, in the style of bug 459972.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Sample update.xml

The new content is 
  promptWaitTime="999"
in the <update> block, for a random choice of time. Please confirm this is the desired format.

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 693809 [details]
Sample update.xml

Looks fine... this would prompt after 999 seconds.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 693808 [details] [diff] [review]
[cvs] Support promptWaitTime in snippets

Landed:
File 	Rev
mozilla/webtools/aus/tests/Verify.py 	1.11
mozilla/webtools/aus/tests/Verify.txt 	1.27
mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/2000000001/locale/channel/complete.txt 	1.2
mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/2000000001/locale/channel/partial.txt 	1.2
mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/2000000002/locale/channel/complete.txt 	1.2
mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/2000000002/locale/channel/partial.txt 	1.2
mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/2000000003/locale/channel/complete.txt 	1.2
mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/2000000003/locale/channel/partial.txt 	1.2
mozilla/webtools/aus/xml/index.php 	1.37
mozilla/webtools/aus/xml/inc/patch.class.php 	1.33
mozilla/webtools/aus/xml/inc/update.class.php 	1.4
mozilla/webtools/aus/xml/inc/xml.class.php 	1.8 

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fwebtools%2Faus%2F&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2012-12-20+15%3A15&maxdate=2012-12-20+15%3A16&cvsroot=%2Fcvsroot

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

After some checks in staging, the tag AUS2_PRODUCTION has been moved to these:
mozilla/webtools/aus/xml/index.php 	1.37
mozilla/webtools/aus/xml/inc/patch.class.php 	1.33
mozilla/webtools/aus/xml/inc/update.class.php 	1.4
mozilla/webtools/aus/xml/inc/xml.class.php 	1.8

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Now deployed to production. I verified that the update.xml for Firefox 16.0.1/17.0/18.0b4/18.0b3 didn't change after the deploy, across all platforms.