Closed Bug 816431 Opened 7 years ago Closed 7 years ago

unprefix CSSRule.MOZ_KEYFRAME{,S}_RULE constants

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: heycam, Assigned: heycam)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Remove the prefix from CSSRule.MOZ_KEYFRAME_RULE and CSSRule.MOZ_KEYFRAMES_RULE, now that we have unprefixed the animation properties.
Attachment #686453 - Flags: review?(bzbarsky)
Attached patch patch (v1.1)Splinter Review
Should really bump the UUID of the interface, too...
Attachment #686453 - Attachment is obsolete: true
Attachment #686453 - Flags: review?(bzbarsky)
Attachment #686454 - Flags: review?(bzbarsky)
Comment on attachment 686454 [details] [diff] [review]
patch (v1.1)

This doesn't need an iid bump, but could you also leave the prefixed versions until we remove support for the prefixed CSS?
Attachment #686454 - Flags: review?(bzbarsky) → review+
Ah yes, sure.  (I don't really have an idea of what changes require IID bumps and which don't.)
The basic rule of thumb is that if it changes the vtable layout it needs an iid bump.
But since you didn't make it pref-controlled, could you at least have a comment that includes the "layout.css.prefixes.animations" pref name, so that we're more likely to remember to remove it when we removed the prefixed stuff?
https://hg.mozilla.org/mozilla-central/rev/9498df71b94c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Keywords: dev-doc-needed
I've documented this by creating the pages:
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframesRule and
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframeRule

They were missing.

I updated:
https://developer.mozilla.org/en-US/docs/DOM/CSSRule and
https://developer.mozilla.org/en-US/docs/Firefox_20_for_developers

A question our current implementation of CSSKeyframe{s}Rule interface are still prefixed. We only unprefixed the constant. Is this correct? If so is there a bug to unprefix them?
You need to log in before you can comment on or make changes to this bug.