816431 - unprefix CSSRule.MOZ_KEYFRAME{,S}_RULE constants

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

Remove the prefix from CSSRule.MOZ_KEYFRAME_RULE and CSSRule.MOZ_KEYFRAMES_RULE, now that we have unprefixed the animation properties.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch (v1.1)

Should really bump the UUID of the interface, too...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 686454 [details] [diff] [review]
patch (v1.1)

This doesn't need an iid bump, but could you also leave the prefixed versions until we remove support for the prefixed CSS?

Comment 3

[Cameron McCormack (:heycam)]

Ah yes, sure.  (I don't really have an idea of what changes require IID bumps and which don't.)

Comment 4

[Boris Zbarsky [:bzbarsky]]

The basic rule of thumb is that if it changes the vtable layout it needs an iid bump.

Comment 5

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9498df71b94c

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

But since you didn't make it pref-controlled, could you at least have a comment that includes the "layout.css.prefixes.animations" pref name, so that we're more likely to remember to remove it when we removed the prefixed stuff?

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9498df71b94c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9498df71b94c

Comment 9

[Cameron McCormack (:heycam)]

Added a comment: https://hg.mozilla.org/integration/mozilla-inbound/rev/8114d2445db9

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Thanks.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8114d2445db9

Comment 12

[Jean-Yves Perrier [:teoli]]

I've documented this by creating the pages:
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframesRule and
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframeRule

They were missing.

I updated:
https://developer.mozilla.org/en-US/docs/DOM/CSSRule and
https://developer.mozilla.org/en-US/docs/Firefox_20_for_developers

A question our current implementation of CSSKeyframe{s}Rule interface are still prefixed. We only unprefixed the constant. Is this correct? If so is there a bug to unprefix them?