unprefix CSSRule.MOZ_KEYFRAME{,S}_RULE constants

RESOLVED FIXED in mozilla20

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla20
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 686453 [details] [diff] [review]
patch

Remove the prefix from CSSRule.MOZ_KEYFRAME_RULE and CSSRule.MOZ_KEYFRAMES_RULE, now that we have unprefixed the animation properties.
Attachment #686453 - Flags: review?(bzbarsky)
(Assignee)

Comment 1

5 years ago
Created attachment 686454 [details] [diff] [review]
patch (v1.1)

Should really bump the UUID of the interface, too...
Attachment #686453 - Attachment is obsolete: true
Attachment #686453 - Flags: review?(bzbarsky)
Attachment #686454 - Flags: review?(bzbarsky)
Comment on attachment 686454 [details] [diff] [review]
patch (v1.1)

This doesn't need an iid bump, but could you also leave the prefixed versions until we remove support for the prefixed CSS?
Attachment #686454 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
Ah yes, sure.  (I don't really have an idea of what changes require IID bumps and which don't.)
The basic rule of thumb is that if it changes the vtable layout it needs an iid bump.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9498df71b94c
(Assignee)

Updated

5 years ago
Blocks: 816045
But since you didn't make it pref-controlled, could you at least have a comment that includes the "layout.css.prefixes.animations" pref name, so that we're more likely to remember to remove it when we removed the prefixed stuff?
Blocks: 762302

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9498df71b94c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9498df71b94c

Updated

5 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 9

5 years ago
Added a comment: https://hg.mozilla.org/integration/mozilla-inbound/rev/8114d2445db9
Thanks.
https://hg.mozilla.org/mozilla-central/rev/8114d2445db9
I've documented this by creating the pages:
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframesRule and
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframeRule

They were missing.

I updated:
https://developer.mozilla.org/en-US/docs/DOM/CSSRule and
https://developer.mozilla.org/en-US/docs/Firefox_20_for_developers

A question our current implementation of CSSKeyframe{s}Rule interface are still prefixed. We only unprefixed the constant. Is this correct? If so is there a bug to unprefix them?
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.