Last Comment Bug 816431 - unprefix CSSRule.MOZ_KEYFRAME{,S}_RULE constants
: unprefix CSSRule.MOZ_KEYFRAME{,S}_RULE constants
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla20
Assigned To: Cameron McCormack (:heycam)
:
Mentors:
Depends on:
Blocks: 816045 762302
  Show dependency treegraph
 
Reported: 2012-11-28 23:44 PST by Cameron McCormack (:heycam)
Modified: 2012-12-11 03:37 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.80 KB, patch)
2012-11-28 23:44 PST, Cameron McCormack (:heycam)
no flags Details | Diff | Splinter Review
patch (v1.1) (4.13 KB, patch)
2012-11-28 23:46 PST, Cameron McCormack (:heycam)
bzbarsky: review+
Details | Diff | Splinter Review

Description Cameron McCormack (:heycam) 2012-11-28 23:44:39 PST
Created attachment 686453 [details] [diff] [review]
patch

Remove the prefix from CSSRule.MOZ_KEYFRAME_RULE and CSSRule.MOZ_KEYFRAMES_RULE, now that we have unprefixed the animation properties.
Comment 1 Cameron McCormack (:heycam) 2012-11-28 23:46:24 PST
Created attachment 686454 [details] [diff] [review]
patch (v1.1)

Should really bump the UUID of the interface, too...
Comment 2 Boris Zbarsky [:bz] 2012-11-28 23:53:30 PST
Comment on attachment 686454 [details] [diff] [review]
patch (v1.1)

This doesn't need an iid bump, but could you also leave the prefixed versions until we remove support for the prefixed CSS?
Comment 3 Cameron McCormack (:heycam) 2012-11-28 23:54:33 PST
Ah yes, sure.  (I don't really have an idea of what changes require IID bumps and which don't.)
Comment 4 Boris Zbarsky [:bz] 2012-11-28 23:56:29 PST
The basic rule of thumb is that if it changes the vtable layout it needs an iid bump.
Comment 5 Cameron McCormack (:heycam) 2012-11-28 23:59:02 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/9498df71b94c
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-11-29 00:33:40 PST
But since you didn't make it pref-controlled, could you at least have a comment that includes the "layout.css.prefixes.animations" pref name, so that we're more likely to remember to remove it when we removed the prefixed stuff?
Comment 7 Ed Morley [:emorley] 2012-11-29 06:23:19 PST
https://hg.mozilla.org/mozilla-central/rev/9498df71b94c
Comment 8 Ed Morley [:emorley] 2012-11-29 06:43:14 PST
https://hg.mozilla.org/mozilla-central/rev/9498df71b94c
Comment 9 Cameron McCormack (:heycam) 2012-11-29 14:18:07 PST
Added a comment: https://hg.mozilla.org/integration/mozilla-inbound/rev/8114d2445db9
Comment 10 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-11-29 14:24:02 PST
Thanks.
Comment 11 Ed Morley [:emorley] 2012-11-30 02:13:18 PST
https://hg.mozilla.org/mozilla-central/rev/8114d2445db9
Comment 12 Jean-Yves Perrier [:teoli] 2012-12-11 03:37:54 PST
I've documented this by creating the pages:
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframesRule and
https://developer.mozilla.org/en-US/docs/DOM/CSSKeyframeRule

They were missing.

I updated:
https://developer.mozilla.org/en-US/docs/DOM/CSSRule and
https://developer.mozilla.org/en-US/docs/Firefox_20_for_developers

A question our current implementation of CSSKeyframe{s}Rule interface are still prefixed. We only unprefixed the constant. Is this correct? If so is there a bug to unprefix them?

Note You need to log in before you can comment on or make changes to this bug.