816549 - "Show variables searchbox" option in the debugger options menu - no such word as "searchbox"

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Eric Shepherd [:sheppy]]

This string should be "Show variables search box" instead.

Comment 1

[Eric Shepherd [:sheppy]]

And actually, since the box it displays is a filter, perhaps it should be "Show variables filter box" instead?

Comment 2

[Girish Sharma [:Optimizer]]

While at it, can that filter box be moved above the add watch expression ? Appearance wise, it look odd to have black toolbar, then white space then again black toolbar with search box.

or may bey change the theme of the filter box.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Girish Sharma [:Optimizer] from comment #2)
> While at it, can that filter box be moved above the add watch expression ?
> Appearance wise, it look odd to have black toolbar, then white space then
> again black toolbar with search box.
> 
> or may bey change the theme of the filter box.

No, these are two different panes, each with it's own functionality. Furthermore, the search box is not necessary (and disabled by default) because there's an operator available for the toolbar search box.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 686692 [details] [diff] [review]
v1

Review of attachment 686692 [details] [diff] [review]:
-----------------------------------------------------------------

Different label please.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v2

http://silellak.com/gifs/ScrubsHeadSlam.gif

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 686718 [details] [diff] [review]
v2

Review of attachment 686718 [details] [diff] [review]:
-----------------------------------------------------------------

OK, but with the same caveat as in bug 816548.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Girish Sharma [:Optimizer] from comment #2)
> While at it, can that filter box be moved above the add watch expression ?
> Appearance wise, it look odd to have black toolbar, then white space then
> again black toolbar with search box.
> 
> or may bey change the theme of the filter box.

When we fix our bastard half-dark, half-light theme, this will no longer be an issue.

Comment 9

[Victor Porof [:vporof][:vp]]

Attachment: v1

Renamed a few variables in debugger-toolbar to make things consistent.

Comment 10

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/bda0c4076ce1

Comment 11

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/bda0c4076ce1