816552 - Metro Panel UI is too tall when "Always show tabs" is enabled and Firefox Start is visible

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Open Metro Firefox and make sure the start page is displayed.
2. Make sure the "Always show tabs" option is enabled.
3. Open the preferences panel.

The panel is displayed too tall, so that the bottom of the preference list is cut off (on a 768px-high screen) and the list is not scrollable.

At first I thought this was a regression from my patch in bug 808314 but I can still reproduce it even after backing out that change.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This seems to happen when #start-container pushes the browser deck down past the bottom of the screen, causing the main <stack> to grow.  This patch fixes that by preventing these elements from enlarging the <stack>.

I'd be a bit happier if I understood more about why this happens in this exact situation, but I've already spent a ton of time trying to figure that out.  :/

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 686666 [details] [diff] [review]
patch

Review of attachment 686666 [details] [diff] [review]:
-----------------------------------------------------------------

This does fix the issue. I would also prefer to better understand what is being sized when and why the tabbar has this side-effect. I suspect we may see the same issue elsewhere, but meantime it looks good to me.

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/f0c584f97ade

Comment 4

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.