Closed Bug 816862 Opened 12 years ago Closed 9 years ago

Multiple visual issues with <textarea> on OS X 10.8 / hidpi

Categories

(Core :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Dolske, Unassigned)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Attached is a screenshot of the right-side of the main textbox on pastebin.mozilla.org (although I don't think any of these issue are specific to that site).

There are multiple visual glitches with how we're rendering the resizer widget, scrollbar, border, and focus-glow. These might all separate fixes, but I wanted to file 1 bug to describe them as they're all kind of interrelated visually. So consider this a holistic tracking bug, and deps off it. :)

A) Resizer issues:

1) Our resizer is 3 diagonal lines, Safari now uses 2. I see screenshots on the web of Safari with 3 on 10.5, so I guess this changed? But we're using native theming when the scrollbar is present, and that gets 3 lines?

2) Our resizer image needs a hidpi version. [toolkit/themes/pinstripe/global/icons/resizer.png and resizer-rtl.png.] (I already have a local patch for this) Note that we only use our resizer image when there isn't a (native) scrollbox present (which is already ok in hidpi).

3) The resizer shifts position when a scrollbar is also present (1 px down and to the right, on the 10.7 screenshot, on the 10.8/hidpi shot it's so far to the right it overlaps the textarea border).


B) Scroll box

1) The scroll bar box is mispositioned in hidpi mode... It's overlapping the top border of the textarea, and the light-grey left-border of the scroll box is not connected to the bottom-border of the textarea. The whole box might also be 1px too far to the right?


C) Borders

1) In hidpi, the textarea borders do not join nicely at the corners. The outermost pixel of the border is missing (making it look slightly rounded), and the border ends just plain meet up in an odd way.

2) In hidpi, the white fill of the the text area is leaking outside the top and right borders by 1px.


D) Focus glow

1) The blue focus glow is anemic in hidpi. On 10.7/lodpi it appears to be 4-5 pixels wide on both Firefox and Safari. On 10.8/hidpi Safari the glow is twice as many pixels wide, whereas Firefox is still the same number of pixels. Since the pixels are physically smaller, the Firefox glow ring thus appears too small.
Hmm, a likely suspect for (D)?

widget/cocoa/nsNativeThemeCocoa.mm#280
#define MAX_FOCUS_RING_WIDTH 4
C3) I get graphic turds when resizing <textarea dir="rtl"></textarea> (along bottom and left border)
(Just files bug 817363 for the general weirdness for how <textarea dir="rtl"> seems to work, even on not-hidpi / not-OSX). Testcase: http://dolske.net/mozilla/tests/rtl/textarea.html
Bug 817366 filed for A2 (hidpi resizer thumb image)
And heycam has filed bug 821213 for the too-thin focus ring (D). Let's keep that as a separate bug, as it applies to everything, not just textareas; marking this as dependent.
Depends on: 821213
I will start working on this one as soon as I received my Retina MP Pro... having a hidpi system helps, meguess :)
Assignee: nobody → mdeboer
Depends on: 846730
Bug 846730 file for C1 and C2 (border rendering)
Assignee: mdeboer → nobody
All the issues I reported for this bug seem to have either been been fixed, or are otherwise no longer present. Textfields look fine. (Well, the resizer still has 3 lines instead of Safari's 2, but I don't think that's a big deal.)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: