821213 - focus rings too thin in HiDPI mode

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Cameron McCormack (:heycam)]

In HiDPI mode, the blue focus rings shown for <textarea>, <input type=button>, etc. in content seem to be not as thick as in other applications and also not as thick as the corresponding controls e.g. in the address bar and other areas of the window chrome.  (I hesitate to raise this as a bug because I prefer the more subtle blue highlighting!)

Comment 1

[Jonathan Kew [:jfkthame]]

I agree - both that there's a discrepancy, and that I quite like the more subtle version we (inadvertently) have! In the interests of consistency with the platform, though, we should try to fix this.

There are hints in the webkit/chromium code and bug tracker that this is related to CGContext{Get,Set}BaseCTM; see GraphicsContext::platformApplyDeviceScaleFactor in platform/graphics/cg/GraphicsContextCG.cpp.

Comment 2

[Markus Stange [:mstange]]

Attachment: v1

On 10.10 the thinness is much more apparent, so we should probably fix this, even if it looks nice.

Comment 3

[Markus Stange [:mstange]]

By the way, thanks for the pointer to CGContextSetBaseCTM, Jonathan. It worked perfectly.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8490179 [details] [diff] [review]
v1

Looks fine to me.

Comment 5

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/293162286fd2

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/293162286fd2