Closed Bug 817472 Opened 7 years ago Closed 7 years ago

Port browser_394759_privatebrowsing.js to the new per-window PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: andreshm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Blocks: 816524
Blocks: pbngentest
Assignee: nobody → andres
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
Attachment #687983 - Flags: review?(ehsan)
Comment on attachment 687983 [details] [diff] [review]
Patch v1

Review of attachment 687983 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, but one question.  This should not pass with bug 816524 backed out, right?  In that case, I'm not sure what the landing plan for this and bug 816524 should be, since bug 816524 also regressed a whole bunch of other tests.  Can you please do a try push with the patch from bug 816524, this one and the MOZ_PER_WINDOW_PRIVATE_BROWSING thing and see what else in the "bc" test is failing?

Thanks!
Attachment #687983 - Flags: review?(ehsan) → review+
Hmm, that's pretty good, it doesn't include any new failures.  I'll push both patches momentarily.
(Filed bug 817931 about the last failure on Linux.)
https://hg.mozilla.org/mozilla-central/rev/7abd1b174578
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.