817472 - Port browser_394759_privatebrowsing.js to the new per-window PB APIs

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/test/browser_394759_privatebrowsing.js

Follow-up from bug 816524.

Comment 1

[Andres Hernandez [:andreshm]]

Attachment: Patch v1

Comment 2

[(no longer active)]

Comment on attachment 687983 [details] [diff] [review]
Patch v1

Review of attachment 687983 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, but one question.  This should not pass with bug 816524 backed out, right?  In that case, I'm not sure what the landing plan for this and bug 816524 should be, since bug 816524 also regressed a whole bunch of other tests.  Can you please do a try push with the patch from bug 816524, this one and the MOZ_PER_WINDOW_PRIVATE_BROWSING thing and see what else in the "bc" test is failing?

Thanks!

Comment 3

[Andres Hernandez [:andreshm]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e38460747ac6

Comment 4

[(no longer active)]

Hmm, that's pretty good, it doesn't include any new failures.  I'll push both patches momentarily.

Comment 5

[(no longer active)]

(Filed bug 817931 about the last failure on Linux.)

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7abd1b174578