817574 - Replace NS_ABS with std::abs

Status: RESOLVED FIXED

(Core :: General, enhancement)

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

std::abs(int/long) lives in <cstdlib> and std::abs(float/double) lives in
<cmath>.  At first I just included the header that I thought was needed
but I discovered that it was easy to make a mistake and use abs(double)
for an integer value, so it seems safer to always include both.
Also, because of NS_COORD_IS_FLOAT we need to have both for nscoord.

https://tbpl.mozilla.org/?tree=Try&rev=eece68407f10

Comment 2

[(no longer active)]

comm-central uses NS_ABS in two places too: <http://mxr.mozilla.org/comm-central/search?string=NS_ABS>.  If you could remove those as well, we could completely get rid of NS_ABS.

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 687746 [details] [diff] [review]
fix

Sorry, forgot comm-central... yes, my intention is to remove NS_ABS completely.

Comment 4

[Mats Palmgren (inactive)]

Attachment: additional fix for comm-central

(not tested yet)

Comment 5

[Mats Palmgren (inactive)]

Is it possible to push both patches together to Try to make a Thunderbird test run
for example?

Comment 6

[(no longer active)]

(In reply to Mats Palmgren [:mats] from comment #5)
> Is it possible to push both patches together to Try to make a Thunderbird
> test run
> for example?

CCing some folks who would know...

Comment 7

[Mike Conley (:mconley) (:⚙️)]

It is indeed - see https://wiki.mozilla.org/ReleaseEngineering/ThunderbirdTryServer#Pushing_mozilla-central_patches

Comment 8

[Mats Palmgren (inactive)]

It seems it didn't pick up the changes in the mozilla/ sub-directory:
https://tbpl.mozilla.org/?usebuildbot=1&tree=Thunderbird-Try&rev=0a64e1309c05

I have one changeset in the comm-central working tree, and one changeset
in the mozilla/ sub-directory in that tree (this is a separate working tree of
m-c as I understand it).  How do I push those two changes *together* to Try?

(I used "hg push -f -rtip  ssh://hg.mozilla.org/try-comm-central" for the
push above, but that didn't work)

Comment 9

[Mats Palmgren (inactive)]

Oh, I have edit some python etc.  Sorry, I didn't realize that *is* the
instructions on how to push a combined c-c/m-c patch...

Comment 10

[Mats Palmgren (inactive)]

https://tbpl.mozilla.org/?usebuildbot=1&tree=Thunderbird-Try&rev=8a34e4ed19b2

Comment 11

[Mats Palmgren (inactive)]

It seems try-comm-central failed to build it for some reason I don't understand.
The "[mq]: mc-817574" cset adds "--apply-patches" in build/client.py-args and
there's a new file named mozilla-817574.patch, what did I miss?

https://tbpl.mozilla.org/?usebuildbot=1&tree=Thunderbird-Try&rev=8a34e4ed19b2
(I can't find any log file, but the self-serve page says "Failure")

Comment 12

[Mark Banner (:standard8)]

There's a known issue with the Mac debug builds failing to run bloat tests, so they are hidden at the moment. If you add &noignore=1 to the url you'll see the hidden builder.

The build passed, the bloat tests didn't, which is expected.

Comment 13

[Mats Palmgren (inactive)]

https://hg.mozilla.org/comm-central/rev/eafbbc84bd3d
https://hg.mozilla.org/integration/mozilla-inbound/rev/3712c48edfd0

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3712c48edfd0