BaselineCompiler: Add missing compare ops

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Posted patch PatchSplinter Review
Attachment #687803 - Flags: review?(kvijayan)
Comment on attachment 687803 [details] [diff] [review]
Patch

Review of attachment 687803 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/BaselineIC-arm.cpp
@@ +27,1 @@
>      switch(op) {

You can use JSOpToCondition. (Maybe this needs to be moved somewhere)
Comment on attachment 687803 [details] [diff] [review]
Patch

Review of attachment 687803 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/BaselineIC-arm.cpp
@@ +27,1 @@
>      switch(op) {

Good find Tom.  Currently JSOpToCondition sits in CodeGenerator-shared-inl.h, and is declared in CodeGenerator-shared.

It can probably moved out to IonMacroAssembler.h - anything that includes CodeGenerator-shared.h will also include the IonMacroAssembler.
Attachment #687803 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 3

7 years ago
Attachment #687839 - Flags: review?(kvijayan)
Attachment #687839 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 4

7 years ago
Second patch:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c19b631c208
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/9c19b631c208
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.