Closed
Bug 817626
Opened 13 years ago
Closed 13 years ago
BaselineCompiler: Add missing compare ops
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
|
7.23 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
|
3.69 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #687803 -
Flags: review?(kvijayan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 687803 [details] [diff] [review]
Patch
Review of attachment 687803 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/arm/BaselineIC-arm.cpp
@@ +27,1 @@
> switch(op) {
You can use JSOpToCondition. (Maybe this needs to be moved somewhere)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 687803 [details] [diff] [review]
Patch
Review of attachment 687803 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/arm/BaselineIC-arm.cpp
@@ +27,1 @@
> switch(op) {
Good find Tom. Currently JSOpToCondition sits in CodeGenerator-shared-inl.h, and is declared in CodeGenerator-shared.
It can probably moved out to IonMacroAssembler.h - anything that includes CodeGenerator-shared.h will also include the IonMacroAssembler.
Attachment #687803 -
Flags: review?(kvijayan) → review+
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #687839 -
Flags: review?(kvijayan)
|
|
||
Updated•13 years ago
|
Attachment #687839 -
Flags: review?(kvijayan) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Whiteboard: [leave open]
|
|
Assignee | |
Comment 5•13 years ago
|
||
Whiteboard: [leave open]
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•