Closed Bug 817626 Opened 9 years ago Closed 9 years ago

BaselineCompiler: Add missing compare ops

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

Attached patch PatchSplinter Review
No description provided.
Attachment #687803 - Flags: review?(kvijayan)
Comment on attachment 687803 [details] [diff] [review]
Patch

Review of attachment 687803 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/BaselineIC-arm.cpp
@@ +27,1 @@
>      switch(op) {

You can use JSOpToCondition. (Maybe this needs to be moved somewhere)
Comment on attachment 687803 [details] [diff] [review]
Patch

Review of attachment 687803 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/BaselineIC-arm.cpp
@@ +27,1 @@
>      switch(op) {

Good find Tom.  Currently JSOpToCondition sits in CodeGenerator-shared-inl.h, and is declared in CodeGenerator-shared.

It can probably moved out to IonMacroAssembler.h - anything that includes CodeGenerator-shared.h will also include the IonMacroAssembler.
Attachment #687803 - Flags: review?(kvijayan) → review+
Attachment #687839 - Flags: review?(kvijayan)
Attachment #687839 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/9c19b631c208
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.