nsAsyncMessageToParent::Run doesn't check if element exists in mASyncMessages

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
7 years ago
4 months ago

People

(Reporter: enndeakin, Assigned: enndeakin)

Tracking

Trunk
mozilla20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
No description provided.
Attachment #687878 - Flags: review?(bugs)
Comment on attachment 687878 [details] [diff] [review]
patch


>   NS_IMETHOD Run()
>   {
>+    if (mRun)
>+      return NS_OK;

if (mRun) {
  return NS_OK;
}
Attachment #687878 - Flags: review?(bugs) → review+
(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #2)
> Backed out for xpcshell timeouts on Windows:
> https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=Rev3%20WINNT%206.
> 1%20mozilla-inbound%20debug%20test%20xpcshell&rev=25c589434eae
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/3e3800d9e4b6

Sorry looks like this was a push prior to yours, you were just really unlucky with retriggers (2 green on push prior, then 6 purples on yours onwards). See bug 821685 for more info.

This should be able to reland.
https://hg.mozilla.org/mozilla-central/rev/f744b51dcf2c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.