817739 - Add more information to synced tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Right now we show titles. It would be very useful if we also displayed favicons and URLs

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We can't support favicons until Sync does. We could try to show favicons _if_ we already have the favicon for the URL in our database.

Comment 2

[Ian Barlow (:ibarlow)]

I figured, darnit.

Just showing favicons we already have seems less useful, tbh. We can try it if it isn't too hard, or just try it with URLs for now. Or it might just make sense to park this until we get better sync support.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Remote tabs theme changed as per specs. This removes the divider from the TabsTray too.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c5a508fc879

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c5a508fc879

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 700639 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature.
User impact if declined: Beautiful remote-tabs list will be missed.
Testing completed (on m-c, etc.): Landed in m-c on 01/12.
Risk to taking this patch (and alternatives if risky): Very low. The layout styles are changed.
String or UUID changes made by this patch: None.

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 700639 [details] [diff] [review]
Patch

Approving patches needed for Bug 817675 , considering all these are needed for private browsing feature landing in FF20 .

Comment 8

[Sriram Ramasubramanian [:sriram]]

Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/e23eeead407f

Comment 9

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 20.0a2 (2013-02-15), Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Tab 2 7.0
-OS: Android 4.0.4