817745 - WeekView - All day events and dates should be fixed at top when scrolling. All day events will expand.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[James Lal [:lightsofapollo]]

Blocking rational:

 - Its very difficult to tell which day is which when scrolling down in week view.
 - All day events start to overlap with other hours/events when there are more then 1-2.

Comment 1

[Jason Smith [:jsmith]]

Must say - this is certainly annoying from testing this. As for my blocking opinion - debatable if it's a P3 blocker or a P4 soft blocker.

Comment 2

[David Scravaglieri [:scravag]]

Annoying enough to be a P3 I guess

Comment 3

[James Lal [:lightsofapollo]]

This could be tricky, might be a better second/third bug kind of thing.

The way week view is implemented each day is its own complete entity/class that we glue together with a "frame". I still want the isolation (one day never knows about another) so we need to provide a shared space (some element) that the frame will give to the respective WeekChild class ( we have this option today which may be sufficient ). 

I suspect the final fix will be smallish but there is some complexity to wire it all together. Bug me or lorchard with questions.

Comment 4

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 7

[Dietrich Ayala (:dietrich)]

Driver retriage: Not holding the release for this. Would take a low risk patch once all blockers are fixed.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Dietrich Ayala (:dietrich) from comment #7)
> Driver retriage: Not holding the release for this. Would take a low risk
> patch once all blockers are fixed.

Ehh...no. I'm still inclined to agree with James on this one. Too annoying of a UX issue - I think it blocks.

Comment 9

[David Scravaglieri [:scravag]]

We absolutly take a patch on this but not a blocker for V1

Comment 10

[Mila Davydova]

This issue is still reproducing with Unagi, build ID 20130104070203
The event is shown only in half of the block available for it in the Week view. The details of the event are not visible.

Comment 11

[James Lal [:lightsofapollo]]

Kevin you up for taking this one?

Comment 12

[amiller]

UCID: calander-142
https://moztrap.mozilla.org/results/case/61679/

Comment 13

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

James - review please if you get a chance. Let's definitely get a real solution so we can remove this CSS when possible.

Comment 14

[James Lal [:lightsofapollo]]

Comment on attachment 700926 [details]
Github pull request pointer

After we check log slow animations.

Comment 15

[James Lal [:lightsofapollo]]

We discussed in IRL, we need to fix the animation issues (possibly regressions?) before we can land this...

Comment 16

[Kevin Grandon :kgrandon]

Appears that there's nothing from log slow animations, but there are some animation issues.

I'm looking into what those could be, and think you're right about something possibly being off the frame causing rendering issues.

Comment 17

[Kevin Grandon :kgrandon]

Comment on attachment 700926 [details]
Github pull request pointer

Approach has changed. Would like another review. Thanks!

Comment 18

[James Lal [:lightsofapollo]]

Comment on attachment 700926 [details]
Github pull request pointer

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Uglier/less useful week view
Testing completed: (Manually) Tested on blank calendar, and on largest calendar I have ever seen with success. This is mostly a UX only set of changes for the week view only. Existing unit tests + some new ones to cover the minor JS changes.

Risk to taking this patch (and alternatives if risky): All day event related regressions in week view only but this is unlikely.

Much Better! I think we should have the "all day" area as a single scrollable area but that is much more difficult and this makes the week view so much more usable.

Lets land this now and we can re-evaluate more intensive changes in 1.1.

Comment 19

[Kevin Grandon :kgrandon]

Comment on attachment 700926 [details]
Github pull request pointer

><html>
><head>
><meta http-equiv="Refresh" content="1;url=https://github.com/mozilla-b2g/gaia/pull/7624">
></head>
><body>
><a href="https://github.com/mozilla-b2g/gaia/pull/7624">Redirecting to pull request.</a>
></body>
></html>

Comment 20

[Kevin Grandon :kgrandon]

Well that did not work at all :-p

Comment 21

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer (new)

Obseleting old pull request.
See above comments on approval.

Comment 22

[Jeni]

Issue repros on build 20130115070201 Dec 5th Kernel Build. The details of the event are not visible. However If you do put a event over a couple hrs  time spand it does show correctly.

Comment 23

[Kevin Grandon :kgrandon]

This is merged to master, if we get approval I can land in v1-train as well. 

https://github.com/mozilla-b2g/gaia/commit/63fd5c01963acf08f398f025b76d3ae00633ed31

Comment 24

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 702379 [details]
Github pull request pointer (new)

This is already landed, so ignoring the open review request and approving for uplift to v1-train branch.

Comment 25

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 4ef2c4ba32d2393319eb630f78989bd1013d3ecb