Closed
Bug 817749
Opened 12 years ago
Closed 12 years ago
Phone - adjust tab title bar to help differentiate main menu from tab menu
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox20 verified, firefox21 verified)
VERIFIED
FIXED
Firefox 20
People
(Reporter: ibarlow, Assigned: sriram)
References
Details
Attachments
(4 files)
48.87 KB,
image/png
|
Details | |
30.33 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
1.66 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
19.70 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Since our new tab tray designs require the use of an action bar menu, we should tweak the title bar design to make it easier to visually distinguish between the main title bar menu icon, and the tab title bar menu icon.
We can probably do this with a simple transition that would involve
1. animating the main menu icon off the screen when the tab tray is opened
2. extending the grey tab bar background all the way across the header
3. show a tab menu icon in a slightly different colour.
Assignee | ||
Comment 1•12 years ago
|
||
Is the menu button's background black or grey? There will be an abrupt switch if its grey on tabs-menu.
Reporter | ||
Comment 2•12 years ago
|
||
That's why we need a quick transition from one title bar to the other.
Assignee | ||
Comment 3•12 years ago
|
||
This flattens the tabs-tray toolbar. No more curvy buttons in tabs-panel. Yaay! no more personas for them!! yaay!! Less XML files! Yaay!!
But we need new blue menu button similar to "+" button. That's the next patch.
Attachment #694008 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•12 years ago
|
||
We have a solid square button. We don't need a delegate anymore.
Attachment #694060 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 5•12 years ago
|
||
And the new menu icons to look good on the tabs-panel.
Attachment #694061 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #694008 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #694060 -
Flags: review?(mark.finkle) → review+
Comment 6•12 years ago
|
||
Comment on attachment 694061 [details] [diff] [review]
Part 3: Menu icons in blue
nice set of patches
Attachment #694061 -
Flags: review?(mark.finkle) → review+
Comment 7•12 years ago
|
||
We still need a transition, as Ian indicates. That could be a followup bug.
Assignee | ||
Comment 8•12 years ago
|
||
Assignee | ||
Comment 9•12 years ago
|
||
And I tried: https://tbpl.mozilla.org/?tree=Try&rev=309d36f10999
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/53952a6be9cf
https://hg.mozilla.org/mozilla-central/rev/0f8373352445
https://hg.mozilla.org/mozilla-central/rev/394a6d8577f7
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment 11•12 years ago
|
||
The changes were applied on both Nightly and Aurora. Closing bug as verified fixed on:
Firefox for Android
Version: 21.0a1 (2013-01-29)
Device: Galaxy R
OS: Android 2.3.4
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•