Phone - adjust tab title bar to help differentiate main menu from tab menu

VERIFIED FIXED in Firefox 20



6 years ago
6 years ago


(Reporter: ibarlow, Assigned: sriram)


Firefox 20
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(firefox20 verified, firefox21 verified)



(4 attachments)



6 years ago
Created attachment 687885 [details]

Since our new tab tray designs require the use of an action bar menu, we should tweak the title bar design to make it easier to visually distinguish between the main title bar menu icon, and the tab title bar menu icon. 

We can probably do this with a simple transition that would involve 

1. animating the main menu icon off the screen when the tab tray is opened
2. extending the grey tab bar background all the way across the header 
3. show a tab menu icon in a slightly different colour.

Comment 1

6 years ago
Is the menu button's background black or grey? There will be an abrupt switch if its grey on tabs-menu.

Comment 2

6 years ago
That's why we need a quick transition from one title bar to the other.

Comment 3

6 years ago
Created attachment 694008 [details] [diff] [review]
Part 1: Flatten the toolbar

This flattens the tabs-tray toolbar. No more curvy buttons in tabs-panel. Yaay! no more personas for them!! yaay!! Less XML files! Yaay!!

But we need new blue menu button similar to "+" button. That's the next patch.
Attachment #694008 - Flags: review?(mark.finkle)

Comment 4

6 years ago
Created attachment 694060 [details] [diff] [review]
Part 2: No sharing

We have a solid square button. We don't need a delegate anymore.
Attachment #694060 - Flags: review?(mark.finkle)

Comment 5

6 years ago
Created attachment 694061 [details] [diff] [review]
Part 3: Menu icons in blue

And the new menu icons to look good on the tabs-panel.
Attachment #694061 - Flags: review?(mark.finkle)
Attachment #694008 - Flags: review?(mark.finkle) → review+
Attachment #694060 - Flags: review?(mark.finkle) → review+
Comment on attachment 694061 [details] [diff] [review]
Part 3: Menu icons in blue

nice set of patches
Attachment #694061 - Flags: review?(mark.finkle) → review+
We still need a transition, as Ian indicates. That could be a followup bug.
Assignee: nobody → sriram
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
The changes were applied on both Nightly and Aurora. Closing bug as verified fixed on:

Firefox for Android
Version: 21.0a1 (2013-01-29)
Device: Galaxy R
OS: Android 2.3.4
status-firefox20: --- → verified
status-firefox21: --- → verified
You need to log in before you can comment on or make changes to this bug.