817790 - Stretched Facebook icon briefly shows over entire toolbar during window startup

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

When open a new window, the entire Toolbar.png set shows briefly stretched over the entire toolbar. Then the provider icon itself shows with the same problem, and after a moment the toolbar icons are properly sizes.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

properly *sized

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This is the regression-window that I was able to find, but nothing jumps out at me.

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=597915b66059&tochange=3c3a8eed0578

Comment 3

[u279076]

The only Social API change I see that touched UI code is bug 813436 (contained in the Nov 27 PGO merge):
http://hg.mozilla.org/mozilla-central/rev/532d0832c09d

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Of the social bugs in that set, I assume bug 813436 is the most likely culprit?

Comment 5

[Mark Hammond [:markh] [:mhammond]]

I can see this in rev 62bb8cc3277b, which is before those social changes landed.  I'll try and narrow it further

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mark Hammond (:markh) from comment #5)
> I can see this in rev 62bb8cc3277b, which is before those social changes
> landed.  I'll try and narrow it further

I screwed up my testing -  bug 813436 is the culprit.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Attachment: set hidden after toolbar init

The problem is that we are updating the broadcaster's hidden attribute before we've set the correct provider image.  This patch shifts the broadcaster update to after the toolbar has been initialized.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 688090 [details] [diff] [review]
set hidden after toolbar init

Review of attachment 688090 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, LGTM.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ce29406488e

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9ce29406488e

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage drive-by: please nominate for Aurora when you can.

Comment 12

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 688090 [details] [diff] [review]
set hidden after toolbar init

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 813436
User impact if declined: Ugly toolbar "flash" when new windows opened.
Testing completed (on m-c, etc.): Landed on m-c
Risk to taking this patch (and alternatives if risky): Low risk, only social code impacted.
String or UUID changes made by this patch: None

Comment 13

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a264305757b9

Comment 14

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 19 RC - during window startup, the stretched Facebook icon isn't shown over the toolbar.  

Verified as fixed on Windows 7, Ubuntu 12.04 and Mac OS X 10.8:
Build ID: 20130215130331 
Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/20100101 Firefox/19.0
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/20100101 Firefox/19.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0

Comment 15

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0

Verified for Firefox 20 beta 6. Windows 7, Ubuntu 12.04. No display issues when using a new window with facebook social enabled.