817816 - Split out WebGLUniformLocation into separate files

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Saurabh Anand [:sawrubh]]

Attachment: Patch v1

Comment 2

[Saurabh Anand [:sawrubh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7108bad8aa2

Comment 3

[Saurabh Anand [:sawrubh]]

Backed out :

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1c03b77fe23

Comment 4

[Saurabh Anand [:sawrubh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/812eb3fb9abe

Comment 5

[Saurabh Anand [:sawrubh]]

No rush, but just checking : will somebody be checking this into the tree ?

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

It's strange that it hasn't been reported here, but the most likely explanation is that it has been merged to mozilla-central, just not reported here. Can you check?

Comment 7

[Justin Wood (:Callek)]

Indeed it has been merged to m-c already, by ehsan but was never commented here -- I suspect there are a whole BUNCH of bugs in this merge that were not updated.

CC'ing ehsan and edmorley because of that, but marking this bug as resolved

https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=812eb3fb9abe

Comment 8

[Ed Morley [:emorley]]

(In reply to Justin Wood (:Callek) from comment #7)
> Indeed it has been merged to m-c already, by ehsan but was never commented
> here -- I suspect there are a whole BUNCH of bugs in this merge that were
> not updated.
> 
> CC'ing ehsan and edmorley because of that, but marking this bug as resolved
> 
> https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=812eb3fb9abe

That merge's bugs were marked; the commit message for this bug just had the wrong bug number, so the comment ended up at bug 817186 comment 5.

https://hg.mozilla.org/mozilla-central/rev/812eb3fb9abe

Please double check bug numbers (ideally copy/paste rather than typing by hand) when setting commit messages, or it breaks hg annotate later on.

Cheers :-)