Sync changes in global/alerts/alert.css from Toolkit (Adjust styling of nsIAlertService alert windows).

RESOLVED FIXED in seamonkey2.17

Status

SeaMonkey
Themes
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

({modern})

Trunk
seamonkey2.17
modern

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.11 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Rollup of changes from:
Bug 769095. Enforce maximum icon size for nsIAlertsService's notification.
Bug 770433 - Update borders and background of alert (toast) notifications on Windows.
Bug 786125 - Alert showing/hiding animation is janky (nsIAlertsService).
Bug 796111. Adjust styling of nsIAlertService alert windows.

See: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/alerts/alert.css
(Assignee)

Comment 1

5 years ago
Created attachment 688230 [details] [diff] [review]
Patch v1.0 Update.

> Bug 786125 - Alert showing/hiding animation is janky (nsIAlertsService)
So now instead of the toaster sliding in, it fades in using opacity+animation.

> See: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/alerts/alert.css

I didn't bother to implement the background-image: linear-gradient(...) bits.

To test use:

Classic:
Components.classes["@mozilla.org/alerts-service;1"]
          .getService(Components.interfaces.nsIAlertsService)
          .showAlertNotification("chrome://global/skin/icons/information-48.png",
                                 "Notification test",
                                 "Surprise! I'm here to test notifications!",
                                 true, "foobarcookie", null);


Modern:
Components.classes["@mozilla.org/alerts-service;1"]
          .getService(Components.interfaces.nsIAlertsService)
          .showAlertNotification("chrome://global/skin/icons/alert-message.gif",
                                 "Notification test",
                                 "Surprise! I'm here to test notifications!",
                                 true, "foobarcookie", null);
Attachment #688230 - Flags: review?(neil)

Comment 2

5 years ago
(In reply to Philip Chee from comment #1)
> So now instead of the toaster sliding in, it fades in using opacity+animation.
Unfortunately that doesn't seem to work on Remote Desktop...

> I didn't bother to implement the background-image: linear-gradient(...) bits.
No, that would probably have been silly.

Comment 3

5 years ago
(In reply to comment #2)
> (In reply to Philip Chee from comment #1)
> > So now instead of the toaster sliding in, it fades in using opacity+animation.
> Unfortunately that doesn't seem to work on Remote Desktop...
I tried it in Classic on another PC and it doesn't actually fade in - it appears, then the content fades in and out, then it disappears...

Comment 4

5 years ago
Comment on attachment 688230 [details] [diff] [review]
Patch v1.0 Update.

>+.alertImageBox {
>+  padding: 8px 0;
It seems that padding: 8px; suffices.
(Modern style is to use 0px instead of just 0.)

>+  -moz-padding-start: 4px;
Not sure what good this does.

> .alertText {
>   -moz-margin-end: 6px;
> }
Probably superfluous now.

> .alertText[clickable="true"] {
>   cursor: pointer;
As is this.

>+@keyframes alert-animation {
>+  from {
>+    opacity: 0;
>+  }
>+  6.25% {
>+    opacity: 1;
>+  }
>+  93.75% {
>+    opacity: 1;
>+  }
>+  to {
>+    opacity: 0;
>+  }
>+}
I guess we need this for the alert to stand any chance of being eyecatching...
Attachment #688230 - Flags: review?(neil) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 688829 [details] [diff] [review]
Patch v1.1 fix nits.

>>+.alertImageBox {
>>+  padding: 8px 0;
> It seems that padding: 8px; suffices.
> (Modern style is to use 0px instead of just 0.)
Fixed.

>>+  -moz-padding-start: 4px;
> Not sure what good this does.
Removed.

>> .alertText {
>>   -moz-margin-end: 6px;
>> }
> Probably superfluous now.
Removed.

>> .alertText[clickable="true"] {
>>   cursor: pointer;
> As is this.
Removed.
Attachment #688230 - Attachment is obsolete: true
Attachment #688829 - Flags: review?(neil)

Updated

5 years ago
Attachment #688829 - Flags: review?(neil) → review+
(Assignee)

Comment 6

5 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/1fbd802f8ebd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
You need to log in before you can comment on or make changes to this bug.