818025 - Disabling progressive rendering and low precision buffers causes crashing

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Lord [:cwiiis]]

If you disable both of these features, it takes a fast-path in BasicTiledThebesLayer which forgets to do a null check and crashes. Silly oversight, patch incoming.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Fix BasicTiledThebesLayer fast-path

Sorry I missed this in the first place, I should've tested more thoroughly.

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 688235 [details] [diff] [review]
Fix BasicTiledThebesLayer fast-path

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Disabling progressive rendering and low-precision tiles causes crashing
User impact if declined: Crashing if the work in bug 817575 is approved.
Testing completed (on m-c, etc.): Tested locally, tiny change.
Risk to taking this patch (and alternatives if risky): Zero.
String or UUID changes made by this patch: None.

Requesting approval to go with the work in bug 817575.

Comment 3

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/7ff74cacf3a1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ff74cacf3a1

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 688235 [details] [diff] [review]
Fix BasicTiledThebesLayer fast-path

low risk, early in Aurora, we can take it there.

Comment 6

[Chris Lord [:cwiiis]]

Pushed to aurora as part of a folded patch: https://hg.mozilla.org/releases/mozilla-aurora/rev/aef9e2eb58da