817575 - Low-precision tiles meta-bug

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Chris Lord [:cwiiis]]

Creating a bug to more easily track and request merge all the work that makes up low-precision tiles that landed after the Aurora cut-off.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Combined changes from dependent bugs

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Blank area where previously the screenshot layer would have been visible
User impact if declined: Higher chance of seeing blank page area when panning fast, or when on complex pages.
Testing completed (on m-c, etc.): Been on m-c for around a week with no complaint.
Risk to taking this patch (and alternatives if risky): Medium risk. This only affects Android and seems to be fine on m-c, but is a large code change. If possible, we don't want to enable progressive tiles without these changes - progressive tiles are already on aurora.
String or UUID changes made by this patch: None.

Comment 2

[Chris Lord [:cwiiis]]

Whoever approves this, could you also let me know if we're prefer this as a single patch or as the 21 separate patches to match m-c? Either way is equal effort for me.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to Chris Lord [:cwiiis] from comment #2)
> Whoever approves this, could you also let me know if we're prefer this as a
> single patch or as the 21 separate patches to match m-c? Either way is equal
> effort for me.

rollup patch for Aurora is fine.  Can you say a bit more about what the product drive is for this work?  It's a lot of work, currently untracked for 19.  I'm wondering when the low-precision tiles is planning to ship, what the demand is, and what kind of test plan there is for this feature to make sure it ships as intended.

Comment 4

[Chris Lord [:cwiiis]]

(In reply to Lukas Blakk [:lsblakk] from comment #3)
> rollup patch for Aurora is fine.  Can you say a bit more about what the
> product drive is for this work?  It's a lot of work, currently untracked for
> 19.  I'm wondering when the low-precision tiles is planning to ship, what
> the demand is, and what kind of test plan there is for this feature to make
> sure it ships as intended.

Progressive tiles are shipping with 19 and are part of the reason we've been able to lower our requirements for that version (which I think is the planned feature) - We've also turned off the screenshot layer though (as it somewhat nullifies the benefit of doing progressive rendering), which means that on these slower phones you can be looking at blank area for quite a while when scrolling a page. I think jpr considered it to be bad enough that we shouldn't ship without some way of mitigating that (which low precision tiles is).

blassey and jpr can comment more authoritatively than I can here.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 687747 [details] [diff] [review]
Combined changes from dependent bugs

Thanks for the extra background - sounds like part of an important feature for 19.  Will expect QA to do testing around this new level of supported devices.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

QA - can we make sure to test early and test often on this feature with the appropriate devices?

Comment 7

[Chris Lord [:cwiiis]]

Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/aef9e2eb58da

Comment 8

[Aaron Train [:aaronmt]]

Been using mozilla-aurora daily since this landed and haven't seen any major issues with this set of patches.