PBM - Adjust title bar background to work with current icons and tab colour

VERIFIED FIXED in Firefox 20

Status

()

P1
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: ibarlow, Assigned: sriram)

Tracking

unspecified
Firefox 20
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(fennec20+)

Details

Attachments

(6 attachments)

(Reporter)

Description

6 years ago
Our title bar icons (refresh, bookmark, menu) are difficult to see with the current private browsing title bar background. We are also adjusting the title bar to only use one tab colour (instead of the lighter grey for normal tabs, and dark grey for private tabs) 

This bug is for replacing the private browsing title bar background with a new colour that makes icons legible, and fits with the normal tab button colour. 

Mockup / assets coming shortly.
(Reporter)

Updated

6 years ago
Blocks: 818072
Assignee: nobody → sriram
tracking-fennec: --- → 20+
Priority: -- → P1
(Reporter)

Comment 1

6 years ago
Created attachment 688465 [details]
Private browsing title bar update

Attached is a revised private browsing UI for title bars on phones and tablets. This should make icons more visible in private browsing, and allow us to show the same colour tab tray in both private and normal browsing.

Changes:
* [PB] darker title bar background
* [PB] darker URL bar background
* [PB] darker back/fwd button background
* [All] Darker tab background (same colour used in private and normal browsing)
* [All] Darker tab number (same colour used in private and normal browsing)
* [All] Darker tab pointer (same colour used in private and normal browsing)

Sriram, please let us know what assets you need to apply these changes.
(Assignee)

Comment 2

6 years ago
Created attachment 688472 [details] [diff] [review]
Part 1: Change menu icons

This changes the menu icons to 3-dotted ones.
Attachment #688472 - Flags: review?(mark.finkle)
Attachment #688472 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 5

6 years ago
(In reply to Ian Barlow (:ibarlow) from comment #1)
> Changes:
> * [PB] darker title bar background
Change for this: https://hg.mozilla.org/mozilla-central/raw-file/tip/mobile/android/base/resources/drawable/address_bar_texture_port_pb.png

> * [PB] darker URL bar background
Change for this: https://hg.mozilla.org/mozilla-central/raw-file/tip/mobile/android/base/resources/drawable/address_bar_url_default_pb.9.png and https://hg.mozilla.org/mozilla-central/raw-file/tip/mobile/android/base/resources/drawable/address_bar_url_pressed_pb.9.png

> * [PB] darker back/fwd button background
One image resource of the new one.

> * [All] Darker tab background (same colour used in private and normal
> browsing)
One image resource like: https://hg.mozilla.org/mozilla-central/raw-file/tip/mobile/android/base/resources/drawable-nodpi/tabs_tray_bg.png

> * [All] Darker tab number (same colour used in private and normal browsing)
It's a color we add: https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/resources/color/tabs_counter_color.xml.in Please specify the new color.

> * [All] Darker tab pointer (same colour used in private and normal browsing)
A bunch like: https://hg.mozilla.org/mozilla-central/raw-file/tip/mobile/android/base/resources/drawable/tabs_carat.png
(Assignee)

Comment 6

6 years ago
Created attachment 689923 [details] [diff] [review]
Part 2: Tabs-Button/Tray

This replaces the resources for tabs-button/tray.
Tabs-button is the same for normal and private modes -- hence we dont need to call setPrivateMode() on it anymore.
Attachment #689923 - Flags: review?(mark.finkle)
(Assignee)

Comment 7

6 years ago
Created attachment 689924 [details] [diff] [review]
Part 3: Address bar background

This replaces the address-bar background.
Attachment #689924 - Flags: review?(mark.finkle)
(Assignee)

Comment 8

6 years ago
Created attachment 689926 [details] [diff] [review]
Part 4: URL bar

This replaces the url-bar resources. It's made a bit tighter (1dp increase in margin/padding) for a better look.
Attachment #689926 - Flags: review?(mark.finkle)
(Assignee)

Comment 9

6 years ago
Created attachment 689956 [details] [diff] [review]
Part 5: about:home

This changes the about:home bg equivalent. This is not used for about:home (as it doesnt have a private mode). This gives the dark black color behind the "awesome bar tabs".
Attachment #689956 - Flags: review?(mark.finkle)
Attachment #689923 - Flags: review?(mark.finkle) → review+
Attachment #689924 - Flags: review?(mark.finkle) → review+
Attachment #689926 - Flags: review?(mark.finkle) → review+
Attachment #689956 - Flags: review?(mark.finkle) → review+

Comment 12

6 years ago
Changes are visible on latest Nightly:

Firefox 20.0a1 (2012-12-18)
Device: Galaxy Nexus
OS: Android 4.1.1

Marking bug as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.