Closed
Bug 818072
Opened 12 years ago
Closed 11 years ago
PBM - Back and forward button enabled / disabled states look reversed
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox20 verified, firefox21 verified, fennec20+)
VERIFIED
FIXED
Firefox 21
People
(Reporter: ibarlow, Assigned: sriram)
References
Details
Attachments
(1 file, 1 obsolete file)
1.16 KB,
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When private browsing on tablets, the back and forward buttons look disabled when they are enabled, and vice versa. It is possible that this issue will be fixed with bug 818071, but I want to track this as a separate bug, just in case we need to do additional work here to fix it.
Updated•12 years ago
|
Assignee: nobody → sriram
tracking-fennec: --- → 20+
Priority: -- → P1
Comment 1•12 years ago
|
||
Was about to file this, yeah the state looks reversed. Tested on my Nexus 7 this morning.
OS: Mac OS X → Android
Hardware: x86 → ARM
Version: unspecified → Firefox 20
Assignee | ||
Comment 2•11 years ago
|
||
We use a filter of #999999 over the disabled icons. Do we use a different color for the private browsing mode? If so what color?
Reporter | ||
Comment 4•11 years ago
|
||
Sriram, you can use #333333 as your overlay colour. Alternately, you can make disabled icons 30% transparent
Flags: needinfo?(ibarlow)
Assignee | ||
Comment 5•11 years ago
|
||
Saved the back button! We are looking soooo gooood!
Attachment #711519 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 6•11 years ago
|
||
Added a null check.
Attachment #711519 -
Attachment is obsolete: true
Attachment #711519 -
Flags: review?(mark.finkle)
Attachment #711525 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #711525 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/46d7188acb0c
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/46d7188acb0c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 711525 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Old code that applies a filter. User impact if declined: A white filter over black url-bar. Testing completed (on m-c, etc.): Landed in m-c on 02/08. Risk to taking this patch (and alternatives if risky): None. String or UUID changes made by this patch: None.
Attachment #711525 -
Flags: approval-mozilla-aurora?
Comment 10•11 years ago
|
||
Comment on attachment 711525 [details] [diff] [review] Patch low risk fix, approving on aurora. Request to QA to help with testing/verification here .
Attachment #711525 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/49d107966e2f
Updated•11 years ago
|
status-firefox20:
--- → fixed
Updated•11 years ago
|
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•