Closed
Bug 818352
Opened 12 years ago
Closed 11 years ago
B2G Multi-SIM: voicemail - add client id in nsIRILContentHelper
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 814634
People
(Reporter: hsinyi, Assigned: aknow)
References
Details
Attachments
(2 files)
232 bytes,
text/html
|
Details | |
9.25 KB,
patch
|
Details | Diff | Splinter Review |
This bug was originally reported in Bug 814584. This bug focuses on re-factoring 'voicemail' related functions and messages. What we probably need to do is: a) nsIRILContentHelper IDL change: add an attribute 'subscriptionId' b) DOM changes: assign '0' (default subscriptionId) in every RILContentHelper function call based on a) c) RIL impl: i) add a property 'subscriptionId' in IPC messages ii) deliver callback to a specific subscriptionId ...
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → htsai
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Updated•12 years ago
|
Blocks: b2g-multi-sim
Updated•11 years ago
|
Assignee: htsai → szchen
Whiteboard: RN5/29
Updated•11 years ago
|
Whiteboard: RN5/29 → RN6/14
Assignee | ||
Comment 2•11 years ago
|
||
I just take a look for the multi-SIM modification on working branch and have a question. Why we could not simplify have multiple provider (ex: telephonyProvider, MobileConnectionProvider) for multi-sim. Then add a member for 'subscriptionId' in RILContentHelper. Details: 1. Add 'subscriptionId' in dom interface. <= Must 2. Create multiple providers in dom, each with a specified 'subscriptionId' value. 3. Wrap cpmm message in RILContentHelper. Automatically add 'subscriptionId' based on its own value. => then we don't have to add a new argument 'subscriptionId' in all functions. The proposal assumes that all the functionality of RILContentHelper should be associate with a sim. So for multi-sim, we just have multiple RILContentHelper
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 792125 [details] [diff] [review] WIP: Add clientId for voicemail Any suggestions?
Attachment #792125 -
Flags: feedback?(htsai)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 792125 [details] [diff] [review] WIP: Add clientId for voicemail change to review
Attachment #792125 -
Flags: feedback?(htsai) → review?(htsai)
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 792125 [details] [diff] [review] WIP: Add clientId for voicemail Review of attachment 792125 [details] [diff] [review]: ----------------------------------------------------------------- Don't we need to carry 'id' in VoicemailStatus?
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #6) > Comment on attachment 792125 [details] [diff] [review] > WIP: Add clientId for voicemail > > Review of attachment 792125 [details] [diff] [review]: > ----------------------------------------------------------------- > > Don't we need to carry 'id' in VoicemailStatus? Yes. We should. The modification requires a dom interface change. I think that it is better to handle the issue with API change in Bug 814634.
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to Szu-Yu Chen [:aknow] from comment #7) > (In reply to Hsin-Yi Tsai [:hsinyi] from comment #6) > > Comment on attachment 792125 [details] [diff] [review] > > WIP: Add clientId for voicemail > > > > Review of attachment 792125 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > Don't we need to carry 'id' in VoicemailStatus? > > Yes. We should. > The modification requires a dom interface change. I think that it is better > to handle the issue with API change in Bug 814634. I rethink about the two bugs. I think it's better and complete to merge them into one, especially when they both are not so large. Sorry about the previous bug planning. I've forgotten why I split them up in this way.
Reporter | ||
Comment 9•11 years ago
|
||
Comment on attachment 792125 [details] [diff] [review] WIP: Add clientId for voicemail Cancelling r? based on comment 8. Thanks.
Attachment #792125 -
Flags: review?(htsai)
Updated•11 years ago
|
Whiteboard: RN6/14
Updated•11 years ago
|
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Updated•11 years ago
|
Summary: B2G Multi-SIM: voicemail - add subscription id in nsIRILContentHelper → B2G Multi-SIM: voicemail - add client id in nsIRILContentHelper
Reporter | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•