818554 - ./mach build (mozconfig python module) dies on set but undefined environment variables like 'DISTCC_LOG='

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

For whatever reason, my environment has a few variables that look like this:

DISTCC_LOG=

where the variable is set, but it has no value. mozconfig.py doesn't like this, particularly at line 319, where it reads past the end of the line because it's expecting something to come after the "=".

Comment 1

[Gregory Szorc [:gps]]

Attachment: Handle empty variables, v1

Relatively straightforward fix with test.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 688866 [details] [diff] [review]
Handle empty variables, v1

Review of attachment 688866 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mozconfig.py
@@ +319,2 @@
>  
> +                    if len(line) == equal_pos + 1:

it would probably be easier to follow if you'd set line[equal_pos + 1:] to some intermediate variable and use that variable.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/c93e85a125db

I rewrote the logic to make it easier to read, per review feedback. I have faith in the unit tests.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Awesome - thanks for fixing this so quickly.