Closed Bug 818606 Opened 12 years ago Closed 12 years ago

Handle empty values in mozbuild's mozconfig parser

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox19 unaffected, firefox20 affected)

Status:
RESOLVED DUPLICATE of bug 818554
Tracking Flags:
Tracking Status
firefox19 --- unaffected
firefox20 --- affected

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Keywords: regression)

Attachments

(1 file)

handle-empty-values.patch
2.34 KB, patch
Details | Diff | Splinter Review 
The mozconfig parser is bug 808357 was unhappy that my mozconfig file defined a variable with an empty string value. I was temporarily disabling some debug code:

  export MY_DEBUG_FLAGS="" ## -DDEBUG_ANDROID_IME"

Question: Should `MY_DEBUG_FLAGS=""` and `MY_DEBUG_FLAGS=` define a variable with an empty string value or just not define a variable? I assume the former.
Attachment #688877 - Flags: review?(mh+mozilla)
Attachment #688877 - Flags: feedback?(gps)
I'm duping this back even though you have a patch since gps has a patch on the other bug.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Attachment #688877 - Flags: review?(mh+mozilla)
Attachment #688877 - Flags: feedback?(gps)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: