818696 - Turning off bluetooth while pairing leaves bluetooth in bad state

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Greg Grisco]

1. Enable Bluetooth from Settings->Bluetooth.
2. Try to pair to another device.  When pairing is in progress, turn off Bluetooth.
3. Turn on Bluetooth after some time (say 30 seconds)

Result:  The pairing failed pop up is seen and bluetooth seems to do nothing as there is no device discovery taking place.  The "Rename my device" button is also disabled.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Hi Eric, can you investigate this?

Thanks!

Comment 2

[Dietrich Ayala (:dietrich)]

Eric, can you provide an estimate how long to take to fix this, and whether it can make C2 or not?

Comment 3

[Eric Chou [:ericchou] [:echou]]

(In reply to Dietrich Ayala (:dietrich) from comment #2)
> Eric, can you provide an estimate how long to take to fix this, and whether
> it can make C2 or not?

We need more discussion about how to solve this. We will fix it before C3.

Eric

Comment 4

[Eric Chou [:ericchou] [:echou]]

We need more tests to make sure what the root cause is. As far as I can tell, this may require small fixes in both Gecko and Gaia. 

I know it's a P1 & C2 bug. We will try to solve this asap.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Evelyn has found the root cause. The patch is incoming.

Comment 6

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #5)
> Evelyn has found the root cause. The patch is incoming.

Updated. 

The root cause is that the pairing failure callback function is invoked after turning on bluetooth, but we still can't be very sure about why this happened. Still looking for a better solution than just providing a workaround, and I'll work on it tomorrow.

Comment 7

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: prevent "pairing failed" prompt from appearing after re-enabling Bluetooth

* This was happened because a callback function was invoked after re-enabling Bluetooth.
* The patch has been tested that it's working. Nevertheless, I still filed a follow-up (Bug 820274) to see if there is a better solution.

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 690756 [details] [diff] [review]
patch 1: v1: prevent "pairing failed" prompt from appearing  after re-enabling Bluetooth

Review of attachment 690756 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me

Comment 9

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8288c4940d1e

Comment 10

[Ed Morley [:emorley]]

Backed out for various crashes:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8288c4940d1e

https://hg.mozilla.org/integration/mozilla-inbound/rev/e54109656e93

Comment 11

[Ed Morley [:emorley]]

Bizarrely the push after the original landing (but before the backout) was green. Maybe this was a compiler bug? Guess we'll find out once some of the runs after that complete.

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The code here not only doesn't build on OS X, it wouldn't compile if we tried.

The problem was elsewhere.

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4db89f8e3fbf

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4db89f8e3fbf

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/62cff4190b80
https://hg.mozilla.org/releases/mozilla-b2g18/rev/f1be41c0ee4d

Comment 16

[Walter Chen[:ypwalter][:wachen]]

fixed in 2012.12.16 build https://releases.mozilla.com/b2g/