Closed
Bug 818829
Opened 13 years ago
Closed 13 years ago
[Settings] The password field shoud be grayed-out/hidden when hotspot WiFi is shared with level security open
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P4)
Tracking
(blocking-b2g:tef+, blocking-basecamp:-, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)
VERIFIED
FIXED
People
(Reporter: arthurcc, Assigned: arthurcc)
References
()
Details
(Keywords: polish)
Attachments
(1 file)
This bug is a follow up of bug 817901.
https://bugzilla.mozilla.org/show_bug.cgi?id=817901
1. Open internet sharing panel.
2. Click Hotspot settings.
3. Set security level as open.
Actual Result: The password field remains visible and editable.
Expected Result: The password field should be grayed-out or hidden.
|
Assignee | |
Comment 1•13 years ago
|
||
Hide the password fields when the security type is open.
Attachment #689545 -
Flags: review?(ehung)
|
|
Assignee | |
Updated•13 years ago
|
blocking-basecamp: --- → ?
|
||
Comment 2•13 years ago
|
||
BB-, P4 - will take a patch.
Please renominate if anything bad will happen when user input some password into password field
|
||
Updated•13 years ago
|
Summary: [Settings] The password field shoud be grayed-out/hidden is WiFi is shared with level security open → [Settings] The password field shoud be grayed-out/hidden when hotspot WiFi is shared with level security open
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 689545 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6873
r=me. sorry for taking so long to finish my review. well done!
Attachment #689545 -
Flags: review?(ehung) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Landed on master. https://github.com/mozilla-b2g/gaia/commit/22f5874ffefdcfcfeb6217ed0be83da80352858e
Thanks Evelyn!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 6•13 years ago
|
||
Duplicate of a blocker
blocking-b2g: --- → tef+
status-b2g18-v1.0.1:
--- → affected
|
||
Comment 7•13 years ago
|
||
Daniel, you beat me on flagging the bug!
status-b2g18:
--- → affected
status-b2g18-v1.0.0:
--- → wontfix
|
|
||
Comment 8•13 years ago
|
||
v1-train: 3a6a4f1fec5f9fbf34c98e9e002fb5523536ab38
v1.0.1: 62a78affe363ea6c8667670147f317d26d3073a7
Flags: in-moztrap+
Verified fixed the following:
The password field is indeed hidden upon clicking hotspot setting and setting the security to open.
Verified on Unagi:
Build ID: 20130325070201
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 701b594c3e320030c538aa19f702764b29a6cc1c
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•